• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

10up / wp_mock
66%
master: 52%

Build:
Build:
LAST BUILD BRANCH: trunk
DEFAULT BRANCH: master
Repo Added 03 Dec 2017 06:54PM UTC
Files 22
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH trunk
branch: SELECT
CHANGE BRANCH
x
  • No branch selected
  • chore/fix-gh-actions
  • chore/update-changelog-v1.1
  • dependabot/composer/composer-65e32c6de6
  • dev
  • feat/add-support-for-types-in-expect-filter-mocks
  • feat/add-with-anything-method-for-on-filter
  • fix/multiple-onfilter-call-issues-related-to-withanyargs-method
  • master
  • trunk

17 Mar 2025 02:27PM UTC coverage: 66.142% (+0.1%) from 66.01%
13901966852

push

github

web-flow
Fix: Multiple `onFilter` call issues related to the `withAnyArgs` method (#259)

# Summary <!-- Required -->

This PR implements a fix for an issue I discovered when using multiple
`onFilter` calls with the `withAnyArgs` method.

<img width="807" alt="Screenshot 2025-03-12 at 18 47 52"
src="https://github.com/user-attachments/assets/3c1bb38a-830a-4a4a-907c-a61b7f0d8e11"
/>

### Closes: #258 

## Details <!-- Optional -->

While writing some unit test cases using the `withAnyArgs` method, I
came across issues for multiple `onFilter` calls introduced into the
tests. At the moment, if a single `onFilter` call is used alongside
`withAnyArgs`, it works correctly, but for multiple cases, it doesn't
correctly pass the tests. The expected behaviour should be that this
works for both single and multiple use cases using the `withAnyArgs`.

This PR fixes this issue correctly.

<img width="587" alt="Screenshot 2025-03-12 at 19 42 19"
src="https://github.com/user-attachments/assets/46cfd651-62a7-455b-9b58-257d38a78b84"
/>

---

Run tests:

```php
vendor/bin/phpunit ./tests/Unit/WP_MockTest.php 
```

## Contributor checklist <!-- Required -->

- [x] I agree to follow this project's [**Code of
Conduct**](https://github.com/10up/.github/blob/trunk/CODE_OF_CONDUCT.md).
- [x] I have updated the documentation accordingly 
- [x] I have added tests to cover changes introduced by this pull
request
- [x] All new and existing tests pass

## Testing <!-- Required -->

```php
public function testMultipleOnFilterPassesWithAnyArgs(): void
{
    WP_Mock::bootstrap();

    /** @phpstan-ignore-next-line */
    WP_Mock::onFilter('testFilter1')
        ->withAnyArgs()
        ->reply('Filtered value 1');

    /** @phpstan-ignore-next-line */
    WP_Mock::onFilter('testFilter2')
        ->withAnyArgs()
        ->reply('Filtered value 2');

    /** @phpstan-ignore-next-line */
    WP_Mock::onFilter('testFilter3')
        ->withAnyArgs()
        ->reply('Filtered value 3');

    $filter... (continued)

0 of 2 new or added lines in 1 file covered. (0.0%)

504 of 762 relevant lines covered (66.14%)

2.68 hits per line

Relevant lines Covered
Build:
Build:
762 RELEVANT LINES 504 COVERED LINES
2.68 HITS PER LINE
Source Files on master
  • Tree
  • List 22
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13901966852 trunk Fix: Multiple `onFilter` call issues related to the `withAnyArgs` method (#259) # Summary <!-- Required --> This PR implements a fix for an issue I discovered when using multiple `onFilter` calls with the `withAnyArgs` method. <img width="807" ... push 17 Mar 2025 02:28PM UTC web-flow github
66.14
13899458772 fix/multiple-onfilter-call-issues-related-to-withanyargs-method Merge bf6125f3e into f25b5895e Pull #259 17 Mar 2025 12:30PM UTC web-flow github
66.01
13899073485 fix/multiple-onfilter-call-issues-related-to-withanyargs-method Merge 601908513 into f25b5895e Pull #259 17 Mar 2025 12:10PM UTC web-flow github
66.01
13819033798 fix/multiple-onfilter-call-issues-related-to-withanyargs-method Merge 411d1c3cd into f25b5895e Pull #259 12 Mar 2025 06:39PM UTC web-flow github
66.14
13818987868 fix/multiple-onfilter-call-issues-related-to-withanyargs-method Merge 3d24b783b into f25b5895e Pull #259 12 Mar 2025 06:37PM UTC web-flow github
66.14
13801039158 trunk Add changelog for v1.1.0 (#257) # Summary <!-- Required --> This updates the changelog prior to tagging the `1.1.0` release. ## Contributor checklist <!-- Required --> - [x] I agree to follow this project's [**Code of Conduct**](https://github... push 12 Mar 2025 12:36AM UTC web-flow github
66.01
13787926791 chore/update-changelog-v1.1 Merge 71abc03cf into 0f27c615d Pull #257 11 Mar 2025 12:24PM UTC web-flow github
66.14
13787664706 trunk Bump symfony/process from 5.4.28 to 5.4.46 in the composer group (#252) Bumps the composer group with 1 update: [symfony/process](https://github.com/symfony/process). Updates `symfony/process` from 5.4.28 to 5.4.46 <details> <summary>Release not... push 11 Mar 2025 12:10PM UTC web-flow github
66.01
13787638219 dependabot/composer/composer-65e32c6de6 Merge b1aeb5205 into 268a7ada8 Pull #252 11 Mar 2025 12:09PM UTC web-flow github
66.01
13787625687 trunk Add support for `withAnyArgs` method for `onFilter` calls. (#256) # Summary <!-- Required --> This PR implements a new method called `withAnyArgs` for `onFilter` calls. This method is particularly useful in test cases where we do not care about ... push 11 Mar 2025 12:08PM UTC web-flow github
66.01
See All Builds (339)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc