01org / ciao
67%
master: 66%

LAST BUILD BRANCH: topic/config-subnet-bits
DEFAULT BRANCH: master
Repo Added
Files 0
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-1007
branch: fix-1007
CHANGE BRANCH
x

368

push

travis-ci

markdryan 
controller: Fix race condition in confirmTenant

This commit ensures that confirmTenant is only successfully called once
for each tenant during any invocation of controller.  The problem is
that confirmTenant is not re-entrant and yet can be called by multiple
go routines simulataneously.  This means that a ciao cluster can be
broken by two commands issued simultaneously on a new tenant.

The tricky thing about fixing this bug is that we cannot really protect
the whole function with a mutex.  The function is potentially very slow
as it optionally needs to wait for a CNCI to launch.  Using a critical
section for the entire function would result in commands for existing
tenants being blocked while a CNCI was launched for a new tenant, which
wouldn't be great.

The fix works by introducing tenant specific channels that provide
synchronisation points for individual tenants.  These channels are
stored in a global map.  This map requires a lock, but the lock only
needs to be held for a short period of time, the time taken to
read or write something to the map.  Thus the act of launching a
CNCI on a tenant blocks only commands on that tenant and not commands
destined for other tenants.

The fix assumes that tenants do not get deleted, and if they do, that
their UUIDs do not get re-used.

Fixes #1007

Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>

14567 of 21821 relevant lines covered (66.76%)

2.15 hits per line

Relevant lines Covered
21821 RELEVANT LINES 14567 COVERED LINES
2.15 HITS PER LINE
Source Files on fix-1007
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
368 fix-1007 controller: Fix race condition in confirmTenant This commit ensures that confirmTenant is only successfully called once for each tenant during any invocation of controller. The problem is that confirmTenant is not re-entrant and yet can be calle... push markdryan travis-ci pending completion  
367 fix-1007 controller: Fix race condition in confirmTenant This commit ensures that confirmTenant is only successfully called once for each tenant during any invocation of controller. The problem is that confirmTenant is not re-entrant and yet was called b... push markdryan travis-ci pending completion  
See All Builds (4535)