3015
83%
master: 72%

Ran 03 Feb 2017 03:27AM UTC

Jobs 1

Files 379

Run time 18s

Badge

Embed ▾

pending completion

Build # 3015

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix race in SubscriberImplTest::receiveMessage (#1586)

This bug manifests as testBundleAcks deadlocking.

The test
1. publishes a series of messages to a mock server,
2. waits to receive them back,
3. and acknowledges them.

For performance reasons, the client does not immediately
send the acknowledgement request to the server.
Instead, it sends acks in batch every 100ms.
Using a fake clock, the test advances the time by 100ms,
sending the ack-batch, then verify that the mock server
receives the acks.

The bug is in step 2. The test thread waits by waiting on a
CountDownLatch, which is counted down by GRPC thread calling
receiveMessage().
However, the method decrements the latch before acking the message.

On a bad day, the test thread can wake up, advance the clock,
and send the ack-batch before the GRPC thread could add the
message to the batch.
The test then waits for the server to receive an ack it never sent,
deadlocking the test.

The fix is for receiveMessage() to ack the message before
decrementing the counter.

Run Details

16789 of 20207 relevant lines covered (83.09%)

161.95 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
9	100.0		google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java

Jobs

ID	Job ID	Ran	Files	Coverage
2	3015.2	03 Feb 2017 03:27AM UTC	0	83.09	Travis Job 3015.2

GoogleCloudPlatform / google-cloud-java / 3015
83%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3015

GoogleCloudPlatform / google-cloud-java / 3015 83% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3015

GoogleCloudPlatform / google-cloud-java / 3015
83%
master: 72%

README BADGES
x