94
88%

Ran 22 Jul 2014 11:23PM UTC

Jobs 3

Files 13

Run time 21s

Badge

Embed ▾

pending completion

Build # 94

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

make cache export refuse to pave .gitgnored files

Summary:
Similar to D12, which fixed a .gitignore bug in import_tree(), we also have a
bug in export_tree(). This time the bug has to do with our dirty file
detection. Normally we fail an export if it would overwrite dirty files, but it
turns out `git checkout` will merrily pave over files that it thinks are
.gitignored.

The solution is to use `git reset --keep`, which apparently doesn't respect
.gitignore. That in turn runs into a tricky issue with timestamps in the index
file. See the big, sorrowful comments in `export_tree`.

https://github.com/oconnor663/peru/issues/15

Test Plan: Extend an existing unit test to include this case.

Reviewers: sean

Differential Revision: https://phabricator.buildinspace.com/D13

Run Details

639 of 693 relevant lines covered (92.21%)

2.76 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	94.1	22 Jul 2014 11:23PM UTC	92.21	Travis Job 94.1
2	94.2	22 Jul 2014 11:23PM UTC	92.06	Travis Job 94.2
3	94.3	22 Jul 2014 11:23PM UTC	92.21	Travis Job 94.3

Source Files on build 94

Detailed source file information is not available for this build.

buildinspace / peru / 94
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 94

buildinspace / peru / 94 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 94

buildinspace / peru / 94
88%

README BADGES
x