projectblacklight / spotlight / 4976

41%

master: 97%

push

travis-ci

refactor Spotlight::Resource reindexing stats tracking and the Spotlight::ReindexProgress that used to use it

* refactor the way Spotlight::Resource tracks indexing stats
  * add items_reindexed_estimate field to create_spotlight_reindexing_log_entries migration
  * resource.rb: refactor Spotlight::Resource#reindex so that it takes an optional ReindexingLogEntry; use the log entry to track the stats that Resource used to keep on itself.  remove unused methods.  update tests.
  * reindex_job.rb: use before_perform hook to update items_reindexed_estimate on the reindexing log entry, if there is one.  pass the log entry to resource.reindex.  add tests.
* refactor Spotlight::ReindexProgress to get a ReindexingLogEntry from an Exhibit, instead of dealing with a Resource list
  * refactor Spotlight::ReindexProgress so that it takes a Spotlight::Exhibit (instead of a Resource list), and uses the current ReindexingLogEntry from the Exhibit (if there is one).  fix Exhibit's call to ReindexProgress and have it initialize the log entries it creates to 0. update exhibit_spec.rb.
    * rewrite reindex_progress_spec.rb
  * reindex_monitor_spec.rb: fix the simulation of a recent reindexing job, slightly relax expectations for reindexing progress text to accommodate multi-digit numbers

31 of 31 new or added lines in 4 files covered. (100.0%)

3019 of 3125 relevant lines covered (96.61%)

454.11 hits per line