182
91%
master: 91%

Ran 01 Feb 2017 03:05PM UTC

Jobs 5

Files 14

Run time 3min

Badge

Embed ▾

pending completion

Build # 182

Build Type

push

travis-ci

Committed by

xolox

Commit Message

Bug fix: Swallow unpickling errors instead of propagating them

In general I am very much opposed to Python code that swallows
exceptions when it doesn't know how to handle them, because it can
inadvertently obscure an issue's root cause and/or exacerbate the
issue.

But caching deserves an exception. Any code that exists solely as an
optimization should not raise exceptions caused by the caching logic.
This should avoid the following traceback which I just ran into:

Traceback (most recent call last):
  File ".../lib/python2.7/site-packages/deb_pkg_tools/cli.py", line 382, in with_repository_wrapper
    with_repository(directory, *command, cache=cache)
  File ".../lib/python2.7/site-packages/deb_pkg_tools/repo.py", line 366, in with_repository
    cache=kw.get('cache'))
  File ".../lib/python2.7/site-packages/deb_pkg_tools/repo.py", line 228, in update_repository
    cache=cache)
  File ".../lib/python2.7/site-packages/deb_pkg_tools/repo.py", line 91, in scan_packages
    fields = dict(inspect_package_fields(archive, cache=cache))
  File ".../lib/python2.7/site-packages/deb_pkg_tools/package.py", line 480, in inspect_package_fields
    value = entry.get_value()
  File ".../lib/python2.7/site-packages/deb_pkg_tools/cache.py", line 268, in get_value
    from_fs = pickle.load(handle)
ValueError: unsupported pickle protocol: 3

Run Details

1264 of 1363 relevant lines covered (92.74%)

4.63 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	182.1	01 Feb 2017 03:05PM UTC	92.74	Travis Job 182.1
2	182.2	01 Feb 2017 03:05PM UTC	92.74	Travis Job 182.2
3	182.3	01 Feb 2017 03:09PM UTC	92.59	Travis Job 182.3
4	182.4	01 Feb 2017 03:05PM UTC	92.59	Travis Job 182.4
5	182.5	01 Feb 2017 03:06PM UTC	92.74	Travis Job 182.5

Source Files on build 182

Detailed source file information is not available for this build.

xolox / python-deb-pkg-tools / 182
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 182

xolox / python-deb-pkg-tools / 182 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 182

xolox / python-deb-pkg-tools / 182
91%
master: 91%

README BADGES
x