6464
85%
master: 87%

Ran 27 Jan 2017 05:50PM UTC

Jobs 1

Files 223

Run time 15s

Badge

Embed ▾

pending completion

Build # 6464

Build Type

push

travis-ci

Committed by

locker

Commit Message

Move inprogress suffix handling out of xlog object

Currently, xlog_create() always appends '.inprogress' suffix to the
given file name, and there's xlog_rename() function that strips the file
name. Such a design decision is bad, because:

 - xlog_rename() name is confusing, because it doesn't allow to rename
   xlog file, it strips its name.
 - Name mangling is unexpected by the caller, which can result in
   garbage in case the caller fails before xlog_rename(). E.g. in case
   of vinyl, '.inprogress' files are never removed, because vinyl does
   not know anything about the suffix.
 - Not all users need this suffix to be appended. E.g. vinyl metadata
   log does not need it at all for now.

That being said, let's move the xlog suffix handling to the upper level
(vinyl, xdir) and add the destination name argument to xlog_rename() to
allow to rename xlog file to any desired name.

Run Details

25893 of 30323 relevant lines covered (85.39%)

957911.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	6464.4 (PACK=coverage)	27 Jan 2017 05:50PM UTC	223	85.39	Travis Job 6464.4

Source Files on build 6464

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tarantool / tarantool / 6464
85%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6464

tarantool / tarantool / 6464 85% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6464

tarantool / tarantool / 6464
85%
master: 87%

README BADGES
x