airbnb / superset / 5559
0%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 23
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5559

Pull #2041

travis-ci

web-flow 
<a href="https://github.com/airbnb/superset/commit/fab3cd502">Fix inner query labels for Vertica

In Vertica, inner queries require different aliases than the main query.

This is an example of query generated before this patch:
SELECT chain AS chain,
                weekstartday AS __timestamp,
                SUM(inventory) AS &quot;Inventory&quot;
FROM mytable
JOIN
  (SELECT chain AS chain__,
                   SUM(inventory) AS &quot;Inventory&quot;
   FROM mytable
   WHERE weekstartday &gt;= &#39;2016-01-24 00:00:00&#39;
     AND weekstartday &lt;= &#39;2017-01-17 00:00:00&#39;
   GROUP BY chain
   ORDER BY &quot;Inventory&quot; DESC LIMIT 50) AS anon_1 ON chain = chain__
WHERE weekstartday &gt;= &#39;2016-01-24 00:00:00&#39;
  AND weekstartday &lt;= &#39;2017-01-17 00:00:00&#39;
GROUP BY chain,
         weekstartday
ORDER BY &quot;Inventory&quot; DESC LIMIT 50000

Which in Vertica produces the error:
Error: (&#39;42702&#39;, &#39;[42702] ERROR 2671: Column reference &quot;inventory&quot; is ambiguous\n (2671) (SQLExecDirectW)&#39;)


And this is the same example after the patch:
SELECT chain AS chain,
                weekstartday AS __timestamp,
                SUM(inventory) AS &quot;Inventory&quot;
FROM mytable
JOIN
  (SELECT chain AS chain__,
                   SUM(inventory) AS mme_inner__
   FROM mytable
   WHERE weekstartday &gt;= &#39;2016-01-24 00:00:00&#39;
     AND weekstartday &lt;= &#39;2017-01-17 00:00:00&#39;
   GROUP BY chain
   ORDER BY mme_inner__ DESC LIMIT 50) AS anon_1 ON chain = chain__
WHERE weekstartday &gt;= &#39;2016-01-24 00:00:00&#39;
  AND weekstartday &lt;= &#39;2017-01-17 00:00:00&#39;
GROUP BY chain,
         weekstartday
ORDER BY &quot;Inventory&quot; DESC LIMIT 50000

Related PR:
https://github.com/airbnb/superset/commit/</a><a class="double-link" href="https://github.com/airbnb/superset/commit/19f537178">19f537178</a>
Pull Request #2041: Fix inner query labels for Vertica

4516 of 5623 relevant lines covered (80.31%)

3.2 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
107
82.39
 0.01% superset/models.py
Jobs
ID Job ID Ran Files Coverage
2 5559.2 (TOX_ENV=py34-postgres) 23
79.98
 Travis Job 5559.2
3 5559.3 (TOX_ENV=py34-sqlite) 23
80.03
 Travis Job 5559.3
4 5559.4 (TOX_ENV=py27-mysql) 23
80.06
 Travis Job 5559.4
5 5559.5 (TOX_ENV=py27-sqlite) 23
80.03
 Travis Job 5559.5
Source Files on build 5559
Coverage ∆ File Lines Relevant Covered Missed Hits/Line