1317
62%

Ran 24 Jan 2017 01:13AM UTC

Jobs 1

Files 611

Run time 33s

Badge

Embed ▾

pending completion

Build # 1317

Build Type

push

travis-ci

Committed by Commit bot

Commit Message

cipd: Avoid unnecessary seeks when reading zip with symlinks.

Symlink bodies (they contain paths to the symlinked files) have been read twice:
  1) When generating manifest.json (in particular "files" section)
  2) When actually extracting the symlink

This generates unnecessary seeking inside zip.Reader. Avoid it by precaches
symlink bodies in memory when extracting them.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2647283002

Run Details

38 of 38 new or added lines in 1 file covered. (100.0%)

34374 of 54845 relevant lines covered (62.67%)

1415.23 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
5	100.0		cipd/client/cipd/local/reader.go

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	common/config/impl/filesystem/sort.go
2	100.0	luci_config/server/cfgclient/backend/testconfig/local_service.go
3	100.0	logdog/appengine/coordinator/endpoints/services/getConfig.go
3	100.0	luci_config/server/cfgclient/config.go
4	100.0	appengine/datastorecache/cache.go
10	100.0	luci_config/appengine/gaeconfig/default.go
13	100.0	common/config/impl/memory/memory.go
14	100.0	server/auth/cache.go
14	100.0	common/isolated/algo.go
14	100.0	luci_config/server/cfgclient/backend/client/client.go
18	100.0	common/config/impl/filesystem/fs.go
30	100.0	server/auth/client.go
33	100.0	luci_config/appengine/backend/datastore/ds.go
37	100.0	common/config/impl/remote/remote.go
43	100.0	cipd/client/cipd/local/files.go
44	100.0	luci_config/appengine/gaeconfig/settings.go
52	100.0	luci_config/server/cfgclient/backend/caching/config.go
53	100.0	cipd/client/cipd/local/reader.go
117	100.0	common/auth/auth.go
139	100.0	cipd/client/cipd/local/deployer.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	1317.1	24 Jan 2017 01:13AM UTC	0	62.67	Travis Job 1317.1

Source Files on build 1317

Detailed source file information is not available for this build.

luci / luci-go / 1317
62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1317

luci / luci-go / 1317 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1317

luci / luci-go / 1317
62%

README BADGES
x