18311
94%

Ran 20 Jan 2017 06:31AM UTC

Jobs 5

Files 195

Run time 10min

Badge

Embed ▾

pending completion

Build # 18311

Build Type

push

travis-ci

Committed by

balloob

Commit Message

Updated ISY component to not overwrite state_attributes. (#5433)

* Updated ISY component to not overwrite state_attributes.

The ISY component included an ISYDevice base class that is used by all
of the isy994 platforms. This still overwrote the state_attributes
property instead of the more appropriate device_state_attributes
property. This was also repeated in the isy994 light platform. Both of
these were addressed. This also fixes issue #5428.

* Removed custom state attributes from ISY lights.

The brightness attribute need not be manually reported by the isy994
light platform.

* Removed ISY Node cleanup.

The ISY entities don’t really need to unsubscribe themselves while hass
is shutting down. Because these updates are not sent in a thread, there
is no negative impact from shutting down without unsubscribing. This
greatly speeds up hass shutdown.

* Removed unused attribute from isy994 light platform.

* Cleaned up ISY994 light entity class.

1) Removed the state property. This property is set in the Entity base
class and shouldn’t be overridden here.
2) Set the brightness property. This is the proper way of setting the
brightness for the Light base class.
3) Removed properties that are now unused because of these changes.

Coverage Stats

16185 of 17286 relevant lines covered (93.63%)

2.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	18311.1 (TOXENV=py34)	20 Jan 2017 06:35AM UTC	93.62	Travis Job 18311.1
2	18311.2 (TOXENV=requirements)	20 Jan 2017 06:31AM UTC		Travis Job 18311.2
3	18311.3 (TOXENV=lint)	20 Jan 2017 06:38AM UTC		Travis Job 18311.3
5	18311.5 (TOXENV=py35)	20 Jan 2017 06:41AM UTC	93.61	Travis Job 18311.5
6	18311.6 (TOXENV=py36)	20 Jan 2017 06:40AM UTC	93.61	Travis Job 18311.6

Source Files on build 18311

Detailed source file information is not available for this build.

home-assistant / home-assistant / 18311
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 18311

home-assistant / home-assistant / 18311 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 18311

home-assistant / home-assistant / 18311
94%

README BADGES
x