25640
83%

Ran 19 Jan 2017 06:36AM UTC

Jobs 20

Files 61

Run time 7min

Badge

Embed ▾

pending completion

Build # 25640

Build Type

Pull #

travis-ci

Committed by Angelo Capilleri

Commit Message

fix truncation in ActiveRecord::Calculations

This PR fixes a wrong conversion to column_type in
`ActiveRecord::Calculations#calculation`
when the calculation has complex fields and the result
is a different type than the column.

This prevent truncation of result and allows the user
to have the original data type of result

Fixes #12937.

  Before:

      Account.sum("2.1 * accounts.credit_limit") => 667

  After:

      Account.sum("2.1 * accounts.credit_limit") => 667.8

Pull Request Pull Request #:

Run Details

2087 of 2481 relevant lines covered (84.12%)

125.03 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
10	25640.10 (ruby-head, GEM=am,amo,as,av,aj)	19 Jan 2017 06:36AM UTC	61	84.03	Travis Job 25640.10
12	25640.12 (jruby-head, GEM=am,amo,as,av,aj)	19 Jan 2017 06:36AM UTC	61	84.03	Travis Job 25640.12
14	25640.14 (ruby-head, GEM=ar:mysql)	19 Jan 2017 06:36AM UTC	61	84.03	Travis Job 25640.14
16	25640.16 (jruby-head, GEM=ar:mysql)	19 Jan 2017 06:37AM UTC	61	84.03	Travis Job 25640.16
17	25640.17 (2.2.2, GEM=ar:mysql2)	19 Jan 2017 06:37AM UTC	61	84.03	Travis Job 25640.17
18	25640.18 (ruby-head, GEM=ar:mysql2)	19 Jan 2017 06:38AM UTC	61	84.03	Travis Job 25640.18
19	25640.19 (rbx-2, GEM=ar:mysql2)	19 Jan 2017 06:38AM UTC	61	84.03	Travis Job 25640.19
20	25640.20 (jruby-head, GEM=ar:mysql2)	19 Jan 2017 06:38AM UTC	61	84.03	Travis Job 25640.20
21	25640.21 (2.2.2, GEM=ar:sqlite3)	19 Jan 2017 06:39AM UTC	61	83.99	Travis Job 25640.21
22	25640.22 (ruby-head, GEM=ar:sqlite3)	19 Jan 2017 06:39AM UTC	61	83.99	Travis Job 25640.22
23	25640.23 (rbx-2, GEM=ar:sqlite3)	19 Jan 2017 06:39AM UTC	61	83.99	Travis Job 25640.23
24	25640.24 (jruby-head, GEM=ar:sqlite3)	19 Jan 2017 06:40AM UTC	61	83.99	Travis Job 25640.24
25	25640.25 (2.2.2, GEM=ar:postgresql)	19 Jan 2017 06:40AM UTC	61	83.99	Travis Job 25640.25
26	25640.26 (ruby-head, GEM=ar:postgresql)	19 Jan 2017 06:41AM UTC	61	83.99	Travis Job 25640.26
27	25640.27 (rbx-2, GEM=ar:postgresql)	19 Jan 2017 06:41AM UTC	61	83.99	Travis Job 25640.27
28	25640.28 (jruby-head, GEM=ar:postgresql)	19 Jan 2017 06:41AM UTC	61	83.99	Travis Job 25640.28
29	25640.29 (2.2.2, GEM=aj:integration)	19 Jan 2017 06:42AM UTC	61	83.99	Travis Job 25640.29
30	25640.30 (ruby-head, GEM=aj:integration)	19 Jan 2017 06:43AM UTC	61	83.99	Travis Job 25640.30
31	25640.31 (rbx-2, GEM=aj:integration)	19 Jan 2017 06:43AM UTC	61	83.99	Travis Job 25640.31
32	25640.32 (jruby-head, GEM=aj:integration)	19 Jan 2017 06:44AM UTC	61	83.99	Travis Job 25640.32

Source Files on build 25640

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

hajee / easy_type / 25640
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25640

hajee / easy_type / 25640 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25640

hajee / easy_type / 25640
83%

README BADGES
x