racker / rackspace-monitoring-poller / 276

61%

push

travis-ci

(feat): Address golint, gocheck, vet, staticcheck, gas, errcheck (#65)

* (feat): Address golint, gocheck, vet, staticcheck, gas, errcheck

This PR addresses golang best practices in our codebase.  I ran a
number of lint and static analysis checks against our codebase and
addressed found issues in the check package.  Due to checks
utilized in other packages, those have been touched as well.

Mainly,

* Added public method comments
* Updated struct and method names based on recommendations
* Added TODOs where we do not check for errors and can terminate early
* Added TODOs on where cyclomatic complexity is higher than recommended (10)

* (fix): Update AddTLSMetrics logic and redundant naming

Also updated context parameter to be first in NewCheck function

* (fix): Forgot to update the context switch in scheduler and tests

* (fix): Update comments on packages and const

* (fix): Update comment for consistency

121 of 121 new or added lines in 15 files covered. (100.0%)

1261 of 1800 relevant lines covered (70.06%)

5.11 hits per line