2882
86%

Ran 18 Jan 2017 05:02PM UTC

Jobs 1

Files 147

Run time 12s

Badge

Embed ▾

pending completion

Build # 2882

Build Type

Pull #2493

travis-ci

Committed by

web-flow

Commit Message

Better handling of tap on invalid/external links

Tap on external urls or invalid links would jump to
document's 1st page. We check first the validity of the
link, and deal with wikipedia links or just show the external
url.
ConfirmBox: allow dismissing/cancelling by taping outside,
to keep UX consistent.

Pull Request Pull Request #2493: ImageViewer widget, better handling of external links, fix some blitbuffer memory leaks

Run Details

94 of 94 new or added lines in 7 files covered. (100.0%)

8558 of 16132 relevant lines covered (53.05%)

298.68 hits per line

New Missed Lines in Diff

Lines	Coverage	File
1	61.03	frontend/document/document.lua
5	55.96	frontend/apps/reader/modules/readerhighlight.lua
6	81.23	frontend/document/credocument.lua
10	18.18	frontend/ui/widget/container/alphacontainer.lua
12	45.71	frontend/ui/widget/confirmbox.lua
14	63.73	frontend/ui/widget/imagewidget.lua
22	37.04	frontend/apps/reader/modules/readerlink.lua

Jobs

ID	Job ID	Ran	Files	Coverage
1	2882.1 (EMULATE_READER=1)	18 Jan 2017 05:02PM UTC	147	53.05	Travis Job 2882.1

Source Files on build 2882

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

koreader / koreader / 2882
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 2882

koreader / koreader / 2882 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 2882

koreader / koreader / 2882
86%

README BADGES
x