JuliaLang / DataStructures.jl / 768

95%

push

travis-ci

<a href="https://github.com/JuliaLang/DataStructures.jl/commit/<a class=hub.com/JuliaLang/DataStructures.jl/commit/f322f20ac0f38e7de7220cb8138d89ac2387409c">f322f20ac<a href="https://github.com/JuliaLang/DataStructures.jl/commit/f322f20ac0f38e7de7220cb8138d89ac2387409c">&quot;&gt;RFC: revert &amp;quot;revert remove HashDict&amp;quot; (#252)

* Revert &amp;quot;Revert &amp;quot;Remove HashDict&quot;&quot;

This reverts commit </a><a class="double-link" href="https://github.com/JuliaLang/DataStructures.jl/commit/<a class="double-link" href="https://github.com/JuliaLang/DataStructures.jl/commit/4a9edb3aadda8d58f2eb97cb73b755fd4ddc917a">4a9edb3aa</a>">4a9edb3aa</a><a href="https://github.com/JuliaLang/DataStructures.jl/commit/f322f20ac0f38e7de7220cb8138d89ac2387409c">.

* Fix getindex for DefaultDictBase

* Previously, `getindex` always called &quot;get!(h::Associative, key, default)&quot;
  to return a default value.
* When DefaultDict was based on HashDict (now deleted) and the
  default value was calculated using a function, a version of this
  function with signature

     get!(h::HashDict, key, default::Base.Callable)

  was called.
* Base.Dict has no such function (nor does DataStructures.OrderedDict),
  so the (incorrect) value returned was the function object which
  generated the default value, not the default value itself.
* Additionally, there were no tests for DefaultDicts with defaults
  generated by a function.

* Fixed so that getindex calls the `do` function form of `get!` when
  appropriate
* Added tests for DefaultDicts with defaults generated by functions

* Restore functionality to push tuples onto DefaultDicts

* Used by Gadfly

14 of 14 new or added lines in 2 files covered. (100.0%)

2104 of 2192 relevant lines covered (95.99%)

657465.75 hits per line