rollerworks / search / 448

100%

push

travis-ci

<a href="https://github.com/rollerworks/search/commit/<a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/<a class="double-link" href="https://git"><a class=hub.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec">d3f43371b<a href="https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/rollerworks/search/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&quot;&gt;d3f43371b&lt;/a&gt;&lt;a href=&quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;lt;a class=&amp;amp;amp;quot;double-link&amp;amp;amp;quot; href=&amp;amp;amp;quot;https://git&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a class=&amp;amp;lt;/a&amp;amp;gt;hub.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;quot;&amp;amp;gt;d3f43371b&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;quot;&amp;amp;amp;gt;&amp;amp;amp;amp;lt;a href=&amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;amp;quot;&amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;lt;a href=&amp;amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;quot;double-link&amp;amp;amp;amp;amp;quot; href=&amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;amp;quot;double-link&amp;amp;amp;amp;amp;amp;quot; href=&amp;amp;amp;amp;amp;amp;quot;https://git&amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;gt;hub.com/rollerworks/search/commit/&amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;amp;quot;double-link&amp;amp;amp;amp;amp;amp;quot; href=&amp;amp;amp;amp;amp;amp;quot;https://git&amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;gt;hub.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;gt;d3f43371b&amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;lt;a href=&amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;lt;a href=&amp;amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;amp;lt;a href=&amp;amp;amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&amp;amp;amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;amp;amp;quot;&amp;amp;amp;amp;amp;amp;amp;amp;gt;refactor #138 Remove &amp;amp;amp;amp;amp;amp;amp;amp;amp;quot;Interface&amp;amp;amp;amp;amp;amp;amp;amp;amp;quot; suffix usage (sstok)

This PR was merged into the 2.0-dev branch.

Discussion
----------

The (new) style guide of Rollerworks forbids that Interfaces are suffixed with “Interface” as this breaks ambiguous naming.

Say we had the SearchFactory class but like to introduce a SearchFactory (Interface), renaming the class is one thing. But now all the typehints and references need to be updated, which can cause some serieus BC breakage.

Second Interfaces suffixes are a form Hungarian notations, which is considered a bad practice for a really long time now. Only traits should be suffixed as they can never change there intention, not can they be type-hinted.

Commits
-------

&amp;amp;amp;amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;amp;amp;amp;quot;double-link&amp;amp;amp;amp;amp;amp;amp;amp;quot; href=&amp;amp;amp;amp;amp;amp;amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;amp;amp;amp;amp;amp;lt;/a&amp;amp;amp;amp;amp;amp;amp;gt;&amp;amp;amp;amp;amp;amp;amp;lt;a class=&amp;amp;amp;amp;amp;amp;quot;double-link&amp;amp;amp;amp;amp;amp;quot; href=&amp;amp;amp;amp;&amp;lt;/a&amp;gt;amp;amp;quot;https://github.com/rollerworks/search/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/rollerworks/search/commit/0307f56d0eacf&amp;lt;/a&amp;gt;8ffcb9fd142dccabdf4a0342dc1&amp;quot;&amp;gt;</a>0307f56d0&lt;/a&gt;&amp;amp;quot;&amp;amp;gt;0307f56d0&amp;amp;lt;/a&amp;amp;gt;&amp;amp;quot;&amp;amp;&lt;/a&gt;gt;0307f56&lt;/a&gt;d0&lt;/a&gt;&lt;a href=&quot;https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec&quot;&gt; Rename some classes to remove interfaces suffix
&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/rollerworks/search/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/rollerworks/search/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/rollerworks/search/commit/</a><a class="double-link" href="https://github.com/rollerworks/search/commit/<a class="double-link" href="https://github.com/rollerworks/search/commit/11565b6e4165c8b5a5957658d0692989ec264431">11565b6e4</a>">11565b6e4</a>">11565b6e4</a>">11565b6e4</a>">11565b6e4</a><a href="https://github.com/rollerworks/search/commit/d3f43371b91bea4bbcb90ffe0f0fe126947abbec"> Remove usage of Interface suffix

2660 of 3076 relevant lines covered (86.48%)

33.76 hits per line