skydive-project / skydive / 595

38%

push

travis-ci

<a href="https://github.com/skydive-project/skydive/commit/<a class=hub.com/skydive-project/skydive/commit/d5f56dc04ed4c5aa7ee339693375f879ef38f1cc">d5f56dc04<a href="https://github.com/skydive-project/skydive/commit/d5f56dc04ed4c5aa7ee339693375f879ef38f1cc">&quot;&gt;flow: fix Metrics() gremlin step

This change fixes following issue:
When LastUpdateMetrics does not exist, instead whole flow.Metric returned.

When flow expire time long enough and flow update window size is small, so
f.Metric.Last is before update window - flow.0LastUpdateMetrics initialized
to empty struct. (See  func (ft *Table) updated(updateFrom int64).

Gremlin request Metrics() on such flow will return flow.Metric instead of 0.

Change-Id: I</a><a class="double-link" href="https://github.com/skydive-project/skydive/commit/<a class="double-link" href="https://github.com/skydive-project/skydive/commit/6e80b4980e53af1738aba334e267073c10dd4601">6e80b4980</a>">6e80b4980</a><a href="https://github.com/skydive-project/skydive/commit/d5f56dc04ed4c5aa7ee339693375f879ef38f1cc">
Signed-off-by: Konstantin Dorfman &lt;dorfman@il.ibm.com&gt;
Reviewed-on: https://softwarefactory-project.io/r/6033
Reviewed-by: Sylvain Afchain &lt;safchain@gmail.com&gt;
Tested-by: Sylvain Afchain &lt;safchain@gmail.com&gt;
Workflow: Sylvain Afchain &lt;safchain@gmail.com>
Tested-by: Jenkins CI <jenkins@softwarefactory-project.io>

7873 of 15200 relevant lines covered (51.8%)

391.65 hits per line