luci / gae / 201
82%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
201

push

travis-ci

Commit bot 
impl/memory: Replace gkvlite with "treapstore".

gkvlite is the treap (tree + heap)-based key/value store used by
"impl/memory"'s backend. While it is very powerful package, its
complexity and ensuing requirements make it a somewhat-imperfect fit.
Specifically, "gkvlite" is built around resources that must be
explicitly allocated and free'd. While this makes a lot of sense for its
on-disk storage functionality, we don't use that functionality, and
integrating snapshot closing into every layer of "impl/memory" is
non-trivial.

Enter "treapstore", a treap-based storage implementation that closesly
mirrors the functionality in "gkvlite" that "impl/memory" uses, but
specifically focuses the in-memory use case. Because "treapstore"
foregoes node reuse and snapshot cleanup, we can rely entirely on Go's
memory manager to clean things up, removing the need to close things.

"treapstore" builds on an extended version of "gkvlite"'s underlying
"gtreap" package which introduces an iterator. This iterator removes the
need for the goroutine- and callback-based iteration implementations
that "impl/memory" used to interface with gkvlite (and "gtreap")'s
VisitItemsAscend method, resulting in signifcantly cleaner and likely
higher perfomant code. "treapstore" iterators don't have any cleanup
requirements. Consqeuently, explicit resource management via "stop" is
no longer necessary to perform iteration.

BUG=chromium:675485
TEST=unit

Review-Url: https://codereview.chromium.org/2604943002
Jobs
ID Job ID Ran Files Coverage
1 201.1 0
Travis Job 201.1
Source Files on build 201
Detailed source file information is not available for this build.