137
86%

Ran 04 Jan 2017 10:25AM UTC

Jobs 1

Files 28

Run time 1s

Badge

Embed ▾

pending completion

Build # 137

Build Type

push

travis-ci

Committed by

ralinc

Commit Message

Fix password confirmation bug during user sign up

The issue: users are allowed to sign up without confirming their
passwords.

The bug: the password_confirmation field was omitted from devise strong
parameters list.

When configuring devise strong parameters if you pass a block to the
`permit` method then you completely override the parameter list. In case
you simply want to add a new field then pass it as `keys` argument. This
way you do not change the default devise behavior but extend it.

In the User model you do not need to explicitly call
`validates_confirmation_of :password` as devise already does that for
you in the `validatable` module. But only if `password_required?` is true.
And that is true if the password_confirmation is present. It was not
working for your case because the password_confirmation was missing.

I also added a spec for the User model.

Run Details

203 of 250 relevant lines covered (81.2%)

3.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	137.1 (2.3.0)	04 Jan 2017 10:25AM UTC	0	81.2	Travis Job 137.1

Source Files on build 137

Detailed source file information is not available for this build.

bpstein / promodel / 137
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 137

bpstein / promodel / 137 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 137

bpstein / promodel / 137
86%

README BADGES
x