48
3%

Ran 03 Jan 2017 12:36PM UTC

Jobs 7

Files 254

Run time 13min

Badge

Embed ▾

pending completion

Build # 48

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

reactions: Clean up popovers and hover logic.

Previously, the emoji reactions popovers were keyed off the
edit_content area, which is problematic because that area was
created/deleted on hover, resulting in orphaned popovers (which
wouldn't close properly normally).  That had been hackishly addressed
in the original PR with the overbroad `$('.popover').remove();`.  To
remove that, we fix the actions popover to always be based on an
element that exists in the page.

There probably more to do here, but this is good enough to merge emoji
reactions and iterate from here.

Run Details

24653 of 27380 relevant lines covered (90.04%)

1.8 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	zerver/lib/create_user.py
1	100.0	zerver/lib/db.py
1	100.0	zerver/lib/i18n.py
1	100.0	zerver/lib/initial_password.py
1	100.0	zerver/lib/integrations.py
1	100.0	zerver/lib/narrow.py
1	100.0	zerver/lib/request.py
1	100.0	zerver/lib/str_utils.py
1	100.0	zerver/tests/test_events.py
1	100.0	zerver/tests/test_i18n.py
1	100.0	zerver/tests/test_unread.py
1	100.0	zerver/views/streams.py
1	100.0	zerver/views/unsubscribe.py
1	100.0	zerver/views/webhooks/crashlytics.py
1	100.0	zerver/views/webhooks/helloworld.py
1	100.0	zerver/views/webhooks/pingdom.py
1	100.0	zerver/views/webhooks/pivotal.py
1	100.0	zerver/views/webhooks/stash.py
1	100.0	zerver/views/webhooks/trello/board_actions.py
1	100.0	zerver/views/webhooks/trello/card_actions.py
1	100.0	zerver/views/zephyr.py
2	100.0	analytics/models.py
2	100.0	zerver/tests/test_bugdown.py
2	100.0	zerver/views/realm.py
2	100.0	zerver/views/webhooks/airbrake.py
2	100.0	zerver/views/webhooks/gitlab.py
2	100.0	zerver/views/webhooks/ifttt.py
2	100.0	zerver/views/webhooks/trello/__init__.py
2	100.0	zproject/test_settings.py
2	100.0	zerver/views/integrations.py
3	100.0	analytics/lib/counts.py
3	100.0	zerver/lib/timestamp.py
3	100.0	zerver/lib/utils.py
3	100.0	zerver/templatetags/app_filters.py
3	100.0	zerver/tests/test_templates.py
3	100.0	zerver/views/webhooks/librato.py
3	100.0	zerver/views/webhooks/taiga.py
3	100.0	zproject/dev_settings.py
4	100.0	zerver/lib/parallel.py
4	100.0	zerver/lib/response.py
4	100.0	zerver/tests/test_auth_backends.py
4	100.0	zerver/tests/test_signup.py
4	100.0	zerver/tests/test_subs.py
4	100.0	zerver/views/webhooks/freshdesk.py
4	100.0	zerver/views/webhooks/semaphore.py
4	100.0	zproject/backends.py
5	100.0	confirmation/models.py
5	100.0	zerver/lib/push_notifications.py
5	100.0	zerver/middleware.py
6	100.0	zerver/lib/message.py
6	100.0	zerver/logging_handlers.py
6	100.0	zerver/tests/test_decorators.py
7	100.0	zerver/lib/bugdown/fenced_code.py
7	100.0	zerver/lib/logging_util.py
7	100.0	zerver/lib/timeout.py
7	100.0	zerver/views/webhooks/jira.py
7	100.0	zerver/tests/test_urls.py
7	100.0	zerver/views/auth.py
8	100.0	zerver/tests/tests.py
9	100.0	zerver/forms.py
9	100.0	zerver/lib/unminify.py
9	100.0	zerver/tests/test_narrow.py
9	100.0	zerver/views/messages.py
10	100.0	zerver/lib/test_runner.py
11	100.0	zerver/views/webhooks/bitbucket2.py
12	100.0	zerver/lib/rate_limiter.py
12	100.0	zerver/lib/test_helpers.py
13	100.0	zerver/views/webhooks/github.py
15	100.0	zerver/lib/test_fixtures.py
17	100.0	zerver/lib/upload.py
17	100.0	zerver/models.py
18	100.0	zerver/lib/html_diff.py
19	100.0	zilencer/views.py
21	100.0	zerver/lib/cache.py
22	100.0	zerver/lib/notifications.py
24	100.0	zerver/lib/ccache.py
26	100.0	zerver/decorator.py
31	100.0	zerver/views/__init__.py
32	100.0	zerver/lib/queue.py
33	100.0	zproject/settings.py
63	100.0	zerver/lib/bugdown/__init__.py
70	100.0	zerver/worker/queue_processors.py
154	100.0	analytics/views.py
182	100.0	zerver/lib/actions.py
195	100.0	zerver/lib/export.py

Jobs

ID	Job ID	Ran	Coverage
1	48.1 (TEST_SUITE=frontend)	03 Jan 2017 12:38PM UTC		Travis Job 48.1
2	48.2 (TEST_SUITE=frontend)	03 Jan 2017 12:38PM UTC		Travis Job 48.2
3	48.3 (TEST_SUITE=backend)	03 Jan 2017 12:40PM UTC	90.03	Travis Job 48.3
4	48.4 (TEST_SUITE=backend)	03 Jan 2017 12:40PM UTC	90.02	Travis Job 48.4
5	48.5 (TEST_SUITE=static-analysis)	03 Jan 2017 12:36PM UTC		Travis Job 48.5
6	48.6 (TEST_SUITE=production)	03 Jan 2017 12:47PM UTC		Travis Job 48.6
7	48.7 (TEST_SUITE=production)	03 Jan 2017 12:49PM UTC		Travis Job 48.7

Source Files on build 48

Detailed source file information is not available for this build.

zulip / zulip / 48
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 48

zulip / zulip / 48 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 48

zulip / zulip / 48
3%

README BADGES
x