1678

Ran 03 Jan 2017 06:03AM UTC

Jobs 1

Files 47

Run time 2s

Badge

Embed ▾

pending completion

Build # 1678

Build Type

push

travis-ci

Committed by

MarshallOfSound

Commit Message

Add a resolver for "Go To URL" modal to follow redirects (#2036)

* Add a resolver for "Go To URL" modal to follow redirects

* WIP Refactor based on requested changes

I believe this covers most of the changes that were requested. I haven't
refactored to using fetch/net yet, as it looks like that is a larger
change. I also haven't written new tests, although the pass-quick logic
does make the failing tests pass again.

* Rename fireURL to goToURL

minor change

* More small fixes (typos and linter issues)

* Replace request calls with fetch

This should be the last thing for basic redirect support, except writing
tests for coverage.

The internal function for resolveURL recursively follows redirects up to
10 times, and returns the resolved URL or error.

* Adding test-cases for resolver, refactored to be testable

* Test for invalid url, refactor for easier testability

* Fix a few formatting issues, add testcase for too many redirects

* Fix test description for stubbed fetch requests

Run Details

1296 of 1405 relevant lines covered (92.24%)

28.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1678.1	03 Jan 2017 06:03AM UTC	0	92.24	Travis Job 1678.1

Source Files on build 1678

Detailed source file information is not available for this build.

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL- / 1678

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1678

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL- / 1678

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1678

README BADGES
x