FluidTYPO3 / flux / 2483
93%

DEFAULT BRANCH: development
Ran
Jobs 2
Files 177
Run time 20s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2483

push

travis-ci

mneuhaus 
[BUGFIX] Hide nested content IRRE field if workspaces active (#1261)

This patch adds a condition before indiscriminately adding the `tx_flux_children` field to TCA display. Adding the field when workspaces is enabled will cause the following problem:

* IRRE field may contain placeholders and removing
   those does not seem immediately possible; the
   IRRE field does not "translate" placeholders to the
   actual target record.
* When saving parent record, new versions of children
   are created if the IRRE field is shown.
* This means a new version is attempted to be created
   for any move placeholders that may be present (which
   happens if you move any content into the parent,
   then edit the parent).
* But versions-of-placeholders is not allowed by TYPO3.

The effect might be partially related to the TYPO3 core itself, if assuming that IRRE fields which show `tt_content` records *should* indeed translate placeholders to their original records before showing them in the IRRE field.

If this assumption is correct then a bugfix for the TYPO3 core might be possible, at which point we can restore this field without worrying about errors preventing correct record saving when workspaces is involved.

PS: Also moves our TCA overrides into the proper TCA overrides folder, and removes the `ext_tables.php` file.

Fix kindly sponsored by MSI Chicago - http://www.msichicago.org/

6155 of 6736 relevant lines covered (91.37%)

25.84 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2483.1 (TYPO3_VERSION=">=7.6.13, <7.6.99") 0
91.35
 Travis Job 2483.1
2 2483.2 (TYPO3_VERSION=">=7.6.13, <7.6.99") 0
91.37
 Travis Job 2483.2
Source Files on build 2483
Detailed source file information is not available for this build.