1852
95%

Ran 23 Dec 2016 02:37PM UTC

Jobs 2

Files 42

Run time 2min

Badge

Embed ▾

pending completion

Build # 1852

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[Hotfix] Fix forward header leaking (#197)

* Add tests to verify if forwarding headers are leaked.

* only set the forwarding header when forwarding over the wire

* update generated code of examples to reflect changes in thrift-gen file.

* test isRemote on Router.

* change the name of the forwarded header and send the keys used in forwarding instead of a static true value

* Address first round of feedback.

* Changed name of cached value

* Add example (which doubles as a test) for self request

* use a list as the return value for GetAll to enforce consistent ordering so the output can be easily glob verified

* use non-naked returns because big function

* Rename perserving to preserving.

* add explanation how the keys are chosen

* add test for multiple keys that is forwarded for

* Rename HasForwardedHeader to relfect its implementation of deleting it.

* fix typo

Run Details

4524 of 4753 relevant lines covered (95.18%)

2.11 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1852.1 (RUN="make test-unit test-race test-examples lint coveralls")	23 Dec 2016 02:37PM UTC	42	95.18	Travis Job 1852.1
3	1852.3 (RUN="make test-unit test-race test-examples lint coveralls")	23 Dec 2016 02:40PM UTC	42	94.99	Travis Job 1852.3

Source Files on build 1852

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / ringpop-go / 1852
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1852

uber / ringpop-go / 1852 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1852

uber / ringpop-go / 1852
95%

README BADGES
x