mbland / go-script-bash / 315

95%

Pull #50

travis-ci

<a href="https://github.com/mbland/go-script-bash/commit/<a class=hub.com/mbland/go-script-bash/commit/<a class="double-link" href="https://git"><a class=hub.com/mbland/go-script-bash/commit/61c49fc4a8d764008d5254d94d9f686ee972cd6b">61c49fc4a<a href="https://github.com/mbland/go-script-bash/commit/61c49fc4a8d764008d5254d94d9f686ee972cd6b">&lt;a href=&quot;https://github.com/mbland/go-script-bash/commit/61c49fc4a8d764008d5254d94d9f686ee972cd6b&quot;&gt;&amp;quot;&amp;gt;log: Work around bash array `export` bug (again)

While running the tests for `_GO_LOG_CONSOLE_FILTER` in the previous
commit (part of #36), the tests would pass under Bash 4.4.5(1)-release,
but not under Bash 3.2.57(1)-release.

Eventually I traced down the fact that under 3.2.57(1)-release,
`_GO_LOG_LEVELS` was getting erased sometime after the call to
`assert_log_equals` and before the call to `assert_log_file_equals`
causing `_@go.log_level_index` to fail for what should&amp;amp;#39;ve been valid log
level names. I reasoned that the `.  &amp;amp;quot;$_GO_USE_MODULES&amp;amp;quot; &amp;amp;#39;log&amp;amp;#39;`
invocation in `assert_log_equals` was causing `_GO_LOG_LEVELS` (and
likely other variables) to go out of scope after it returned, and since
`$_GO_USE_MODULES` ensures a module is imported only once, that variable
wasn&amp;#39;t redefined—and there would&amp;#39;ve been errors with re-importing the
module anyway due to `readonly` variables, as mentioned in commit
&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/mbland/go-script-bash/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/mbland/go-script-bash/commit/9c2ae73f707c04b9ea8a09d386727d6c4d4044b2&quot;&gt;9c2ae73f7&lt;/a&gt;&quot;&gt;9c2ae73f7&lt;/a&gt;&lt;a href=&quot;https://github.com/mbland/go-script-bash/commit/61c49fc4a8d764008d5254d94d9f686ee972cd6b">.

Bash 4.4.5(1)-release didn&#39;t have this problem, and it started to ring
familiar. After scanninng the repo history, I realized this is my second
encounter with this bug, the first being documented in commit
</a><a class="double-link" href="https://github.com/mbland/go-script-bash/commit/<a class="double-link" href="https://github.com/mbland/go-script-bash/commit/b421c7382fc1dafb4d865d2357276168eac30744">b421c7382</a>">b421c7382</a><a href="https://github.com/mbland/go-script-bash/commit/61c49fc4a8d764008d5254d94d9f686ee972cd6b">.

The bug is this: Declaring a global array and initializing it at the
same time triggers a bug in some versions of bash 4.x prior to ~4.25
whereby it won't be visible outside the function in which it's declared
after all. See:

- https://lists.gnu.org/a... (continued)

67 of 67 new or added lines in 4 files covered. (100.0%)

1784 of 1892 relevant lines covered (94.29%)

135.22 hits per line