11
100%

Ran 21 Dec 2016 09:23AM UTC

Jobs 5

Files 1

Run time 18s

Badge

Embed ▾

pending completion

Build # 11

Build Type

Pull #3

travis-ci

Committed by

web-flow

Commit Message

move handler into middleware and save in a lexical

There was a change somewhere (probably in Catalyst) at some point that made $env in $c->req->env not be the same as the $env we have in the handler. I believe it gets copied or weakened somewhere, but I could not find it. If $c->req->env or $c->engine->env (which is just for back compatibility and there are comments saying it will go away) are used inside of process in a Catalyst::View:: class, the old approach using $env in the debug pannel works. But we cannot do that here, because it needs to be generic so it works with any View class, and Catalyst::View::process gets overwritten by subclasses, so we cannot add a modifier to it as it's never called.

This solution of adding the handler with a closure over a local variable inside of the actual middleware function is less performant as it gets called every time and not just when the class is loaded. But since we're in a development environment when this gets used that shouldn't be a big problem.

Fixes #1

Pull Request Pull Request #3: move handler into middleware and save in a lexical

Run Details

20 of 20 relevant lines covered (100.0%)

7.0 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	11.1	21 Dec 2016 09:23AM UTC	100.0	Travis Job 11.1
2	11.2	21 Dec 2016 09:24AM UTC	100.0	Travis Job 11.2
3	11.3	21 Dec 2016 09:24AM UTC	100.0	Travis Job 11.3
4	11.4	21 Dec 2016 09:24AM UTC	100.0	Travis Job 11.4
5	11.5	21 Dec 2016 09:24AM UTC	100.0	Travis Job 11.5

Source Files on build 11

Detailed source file information is not available for this build.

markwellis / plack-middleware-debug-catalyststash / 11
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11

markwellis / plack-middleware-debug-catalyststash / 11 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11

markwellis / plack-middleware-debug-catalyststash / 11
100%

README BADGES
x