2786
72%

Ran 08 Dec 2016 04:52PM UTC

Jobs 1

Files 390

Run time 20s

Badge

Embed ▾

pending completion

Build # 2786

Build Type

push

travis-ci

Committed by

garrettjonesgoogle

Commit Message

pubsub: fix testStartStopReset (#1453)

The test verifies that calling stop() actually stops the emulator.
The previous implementation stops the emulator by
- sending HTTP POST to /shutdown
- terminating the emulator process
The second step follows directly after the first.
It then queries the server it just shut down to make sure it does not
respond.

This behavior is incorrect for two reasons.
- The server might continue serving request after responding to
  /shutdown.
- The "emulator process" might not be the emulator at all.
  It might be a script that in-turn runs the emulator.
  On UNIX systems, killing a parent process does not kill any of its
  children; the actual emulator might run indefinitely after
  we kill the process we spawned.

This commit changes this behavior.
After POSTing to /shutdown, we simply wait for the spawned process
to terminate on its own.

Technically, there is still a race:
Another emulator could have been started on the same port.
When we send a request to verify that the old emulator has terminated,
we might get a response from the new one.
Since we execute tests sequentially though,
I believe this should not be a problem in practice.

Run Details

17031 of 20388 relevant lines covered (83.53%)

120.91 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	2786.2	08 Dec 2016 04:52PM UTC	0	83.53	Travis Job 2786.2

Source Files on build 2786

Detailed source file information is not available for this build.

GoogleCloudPlatform / google-cloud-java / 2786
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2786

GoogleCloudPlatform / google-cloud-java / 2786 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2786

GoogleCloudPlatform / google-cloud-java / 2786
72%

README BADGES
x