brutasse / graphite-api / 381
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 20
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
381

push

travis-ci

brutasse 
glyph: Use explicit None comparison in getExtents (#205)

* glyph: Use explicit None comparison in getExtents

Consistently seeing incorrect behaviour/crashing on the /render endpoint
due to the changed line seemingly doing the wrong thing.

Do a more explicit comparison to ensure the correct thing is being
checked, or else I get the following exception:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib/python2.7/site-packages/graphite_api/app.py", line 455, in render
    image = doImageRender(request_options['graphClass'], graph_options)
  File "/usr/lib/python2.7/site-packages/graphite_api/app.py", line 591, in doImageRender
    img = graphClass(**graphOptions)
  File "/usr/lib/python2.7/site-packages/graphite_api/render/glyph.py", line 383, in __init__
    self.drawGraph(**params)
  File "/usr/lib/python2.7/site-packages/graphite_api/render/glyph.py", line 915, in drawGraph
    self.drawLabels()
  File "/usr/lib/python2.7/site-packages/graphite_api/render/glyph.py", line 1762, in drawLabels
    self.drawText(label, x, y, align='center', valign='top')
  File "/usr/lib/python2.7/site-packages/graphite_api/render/glyph.py", line 452, in drawText
    'center': extents['width'] / 2,
KeyError: 'width'

* glyph: tests: fix getExtents test to use the correct class

4254 of 4485 relevant lines covered (94.85%)

0.95 hits per line

Jobs
ID Job ID Ran Files Coverage
11 381.11 (TOXENV=coverage) 0
94.85
 Travis Job 381.11
Source Files on build 381
Detailed source file information is not available for this build.