14602
86%

Ran 29 Nov 2016 02:36AM UTC

Jobs 1

Files 239

Run time 23s

Badge

Embed ▾

pending completion

Build # 14602

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[Fiber] Support iterables (#8446)

* Add iterable cases to MultiChildReconcile test

Stack currently supports rendering iterables, but Fiber does not.

Previously we didn't have any public API tests for iterables. We have tests for traverseAllChildren() which is shared between React.Children and Stack. However Fiber doesn't currently use it, and likely won't. So this commit is a first step towards actually testing iterable support via public API. The next step will be to port traverseAllChildren() tests to test React.Children API instead.

* Implement iterable reconciliation in Fiber

This uses the same exact algorithm as array reconciliation but uses iterator to step through.

This gets reconcile tests to pass again but introduces a regression in ReactMultiChildText case which uses Maps as children. It passed before because Maps were ignored, but now it's failing because this actually runs the Map code path in Fiber. We can throw early in this case when we want to follow up on this.

* Rewrite traverseAllChildren() tests against React.Children API

This function was used in React.Children and Stack.

The corresponding reconciliation functionality is being tested by ReactMultiChild tests.

So we can move these tests to ReactChildren and test its public API.

Run Details

8354 of 10041 relevant lines covered (83.2%)

2485.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	14602.2 (TEST_TYPE=test)	29 Nov 2016 02:36AM UTC	0	83.2	Travis Job 14602.2

Source Files on build 14602

Detailed source file information is not available for this build.

facebook / react / 14602
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14602

facebook / react / 14602 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14602

facebook / react / 14602
86%

README BADGES
x