1718

pending completion

Build # 1718

Build Type

Pull #456

travis-ci

Committed by

web-flow

Commit Message

Handle directories with odd names

Previously, adding a directory with square brackets
resulted in a strange, silent error [1]. This happened
because directory names were being passed to a file-
matching glob designed to recursively stream files from
the directory. When filenames contained meaningful glob
symbols (like [ or *), the glob matching would fail.

This commit resolves this problem by escaping glob
characters on filenames, before the filename is inserted
into the main glob in src/get-file-streams.js L48.
We add a dependency to glob-escape in the process,
and a new test in test/ipfs-api/util.spec.js.

Pull Request Pull Request #456: Handle directories with odd names

Run Details

768 of 952 relevant lines covered (80.67%)

50.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.89

/src/get-files-stream.js

Build SHA Not Found

The commit SHA "0f3c03c9ddc68d22b056c893d5e176ba3422e9c9" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

ipfs / js-ipfs-api / 1718

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous