1718
85%

Ran 28 Nov 2016 12:17AM UTC

Jobs 2

Files 37

Run time 54s

Badge

Embed ▾

pending completion

Build # 1718

Build Type

Pull #456

travis-ci

Committed by

web-flow

Commit Message

Handle directories with odd names

Previously, adding a directory with square brackets
resulted in a strange, silent error [1]. This happened
because directory names were being passed to a file-
matching glob designed to recursively stream files from
the directory. When filenames contained meaningful glob
symbols (like [ or *), the glob matching would fail.

This commit resolves this problem by escaping glob
characters on filenames, before the filename is inserted
into the main glob in src/get-file-streams.js L48.
We add a dependency to glob-escape in the process,
and a new test in test/ipfs-api/util.spec.js.

Pull Request Pull Request #456: Handle directories with odd names

Run Details

768 of 952 relevant lines covered (80.67%)

50.8 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
6	88.89	0.21%	../src/get-files-stream.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	1718.1 (CXX=g++-4.8)	28 Nov 2016 12:17AM UTC	37	80.67	Travis Job 1718.1
3	1718.3 (CXX=g++-4.8)	28 Nov 2016 12:18AM UTC	37	80.67	Travis Job 1718.3

Source Files on build 1718

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ipfs / js-ipfs-api / 1718
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1718

ipfs / js-ipfs-api / 1718 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1718

ipfs / js-ipfs-api / 1718
85%

README BADGES
x