570
95%

Ran 21 Jun 2014 11:47AM UTC

Jobs 7

Files 24

Run time 6min

Badge

Embed ▾

pending completion

Build # 570

Build Type

push

travis-ci

Committed by

ixti

Commit Message

Explicitly stringify readpartial result

Consuming chunked stream may lead into unexpected `nil`s at any time of
consumption. Thus we should return `nil` only when `@socket` was closed.

Chunked responses are streamed in chunks. Each (full) chunk consist of:

  BYTES CRLF
  DATA CRLF

But socket does not care about consistency of those chunk, thus it's
common when we got only first part: `BYTES CRLF`. At this point we feed
this to http_parser which does not emits `on_data` event and our own
Parser `@chunk` ivar remains `nil` after previous flush.

This is no an ideal solution. Ideally we should relay explicitly on
http_parser `#finished?` flag instead. So this should be kept in mind
upon connection exctraction and refactoring.

Resolves #137

Run Details

685 of 732 relevant lines covered (93.58%)

154.64 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	570.2 (1.9.2)	21 Jun 2014 11:48AM UTC	93.88	Travis Job 570.2
3	570.3 (1.9.3)	21 Jun 2014 11:46AM UTC	95.01	Travis Job 570.3
5	570.5 (2.1.0)	21 Jun 2014 11:47AM UTC	95.01	Travis Job 570.5
6	570.6 (rbx-2)	21 Jun 2014 11:51AM UTC	97.78	Travis Job 570.6
7	570.7 (ruby-head)	21 Jun 2014 11:49AM UTC	95.01	Travis Job 570.7
9	570.9 (jruby-19mode, JRUBY_OPTS="$JRUBY_OPTS --debug")	21 Jun 2014 11:51AM UTC	94.89	Travis Job 570.9
10	570.10 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug")	21 Jun 2014 11:53AM UTC	94.89	Travis Job 570.10

Source Files on build 570

Detailed source file information is not available for this build.

tarcieri / http / 570
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 570

tarcieri / http / 570 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 570

tarcieri / http / 570
95%

README BADGES
x