5199
87%

Ran 20 Jun 2014 07:25PM UTC

Jobs 2

Files 354

Run time 5699min

Badge

Embed ▾

pending completion

Build # 5199

Build Type

Pull #1776

travis-ci

Committed by

vitorbaptista

Commit Message

[#1776] Fix bug when upserting [] on JSON column in the datastore

We were testing that the new value wasn't `None` using `if value`. As `[]` is a
falsy value, we never went through that `if` and ended up trying to run an
invalid SQL query.

This commit fixes that by explictly testing `if value is not None`.

This was first discovered in
http://stackoverflow.com/questions/24207065/inserting-empty-arrays-in-json-type-fields-in-datastore

Pull Request Pull Request #1776: Inserting empty arrays in JSON type fields in datastore fails

Run Details

33073 of 39008 relevant lines covered (84.79%)

1.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5199.1 (PGVERSION=8.4)	24 Jun 2014 06:21PM UTC	354	84.18	Travis Job 5199.1
2	5199.2 (PGVERSION=9.1)	20 Jun 2014 07:25PM UTC	354	84.73	Travis Job 5199.2

Source Files on build 5199

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ckan / ckan / 5199
87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5199

ckan / ckan / 5199 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5199

ckan / ckan / 5199
87%

README BADGES
x