1629
0%

Ran 14 Nov 2016 03:31AM UTC

Jobs 5

Files 1

Run time 10min

Badge

Embed ▾

pending completion

Build # 1629

Build Type

push

travis-ci

Committed by

jyaworski

Commit Message

Reorganize templates for clearer understanding (#970)

Without this change, the structure of the templates for locations are
bit rigid and hard to understand.  Each component of a location uses an
isolated template which means that much of the common logic is hard
coded to a particular location style, the deployment of which is chosen
based on a somewhat arbitrary idea of what it means to be a location,
and in some cases, the module gets it wrong.  In cases where there is
seeming correctness, modifications to a particular selection of logic
are duplicated among the nested templates.

This work is the results of what was necessary for me to understand what
the templates were doing, and to deploy a fastcgi PHP application.  As
such, the templates have been centralized and conditions about their
functionality have been moved into the template to determine if
rendering needs to be taken.  This allows a more complete, and leaves
potential for more complex examples easier to understand and reason
about.

Also here is the addition of a new param fastcgi_index on the location
class.

This work should result in on-disk configurations that are functionally
equivalent to what was in place before, except in places where the
module was masking conflicting options that were not being rendered in
the templates.

Run Details

6 of 6 relevant lines covered (100.0%)

5.0 hits per line

Jobs

ID	Job ID	Ran	Coverage
3	1629.3 (2.1.9, PUPPET_VERSION="~> 3.0" STRICT_VARIABLES="yes" CHECK=test)	14 Nov 2016 03:31AM UTC	100.0	Travis Job 1629.3
4	1629.4 (2.1.9, PUPPET_VERSION="~> 4.0" CHECK=test)	14 Nov 2016 03:32AM UTC	100.0	Travis Job 1629.4
5	1629.5 (2.2.5, PUPPET_VERSION="~> 4.0" CHECK=test)	14 Nov 2016 03:32AM UTC	100.0	Travis Job 1629.5
8	1629.8 (2.3.1, PUPPET_VERSION="~> 4.0" CHECK=test)	14 Nov 2016 03:38AM UTC	100.0	Travis Job 1629.8
9	1629.9 (2.4.0-preview1, PUPPET_VERSION="~> 4.0" CHECK=test)	14 Nov 2016 03:41AM UTC	100.0	Travis Job 1629.9

Source Files on build 1629

Detailed source file information is not available for this build.

voxpupuli / puppet-nginx / 1629
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1629

voxpupuli / puppet-nginx / 1629 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1629

voxpupuli / puppet-nginx / 1629
0%

README BADGES
x