calebthompson / time_for_a_boolean / 35

90%

Pull #13

travis-ci

<a href="https://github.com/calebthompson/time_for_a_boolean/commit/<a class=hub.com/calebthompson/time_for_a_boolean/commit/<a class="double-link" href="https://git"><a class=hub.com/calebthompson/time_for_a_boolean/commit/29dee79583aafd4ec71778b82bb2cb8256905706">29dee7958<a href="https://github.com/calebthompson/time_for_a_boolean/commit/29dee79583aafd4ec71778b82bb2cb8256905706">&lt;a href=&quot;https://github.com/calebthompson/time_for_a_boolean/commit/29dee79583aafd4ec71778b82bb2cb8256905706&quot;&gt;&amp;quot;&gt;Switch to using Rails 5 false values instead of true

First, rails removed TRUE_VALUES, leaving FALSE_VALUES: https://github.com/rails/rails/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/calebthompson/time_for_a_boolean/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/calebthompson/time_for_a_boolean/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61&quot;&gt;a502703c3&lt;/a&gt;&quot;&gt;a502703c3&lt;/a&gt;&lt;a href=&quot;https://github.com/calebthompson/time_for_a_boolean/commit/29dee79583aafd4ec71778b82bb2cb8256905706">

Then, the file containing FALSE_VALUES was moved to ActiveModel: https://github.com/rails/rails/commit/</a><a class="double-link" href="https://github.com/calebthompson/time_for_a_boolean/commit/<a class="double-link" href="https://github.com/calebthompson/time_for_a_boolean/commit/9cc8c6f3730df3d94c81a55be9ee1b7b4ffd29f6">9cc8c6f37</a>">9cc8c6f37</a><a href="https://github.com/calebthompson/time_for_a_boolean/commit/29dee79583aafd4ec71778b82bb2cb8256905706">#diff-9a8a85e0f8b322dc1f9bd9c460c204b8

I decided to use the new FALSE_VALUES constant and switch the conditional around to maintain old behavior.

4 of 4 new or added lines in 1 file covered. (100.0%)

19 of 21 relevant lines covered (90.48%)

4.62 hits per line