tarantool / tarantool / 5727

76%

master: 87%

push

travis-ci

iproto: make sure throttled connections are finally woken up

If a message arrives when there is no output for the connection and the
IPROTO_MSG_MAX limit is hit, the input will never be processed unless
the other end writes more data to the socket.

To make sure a throttled connection will be woken up eventually when the
number of pending requests grows below IPROTO_MSG_MAX, let's link all
throttled connections in a list and woke the oldest element from it
whenever a messages is freed.

The issue was initially attempted to be fixed by commit 52b479518
("Don't stop connection if there is no pending requests") by allowing to
exceed the IPROTO_MSG_MAX limit. That commit, however, introduced the
possibility of a deadlock due to depleting the fiber pool, which was
"resolved" by commit 9492cddb ("iproto: fix IPROTO_MSG_MAX check") while
reintroducing the original issue. I hope this patch will finally resolve
all the problems.

25 of 25 new or added lines in 1 file covered. (100.0%)

24594 of 32342 relevant lines covered (76.04%)

747453.46 hits per line