1912
100%

Ran 06 Nov 2016 05:33AM UTC

Jobs 1

Files 66

Run time 3s

Badge

Embed ▾

pending completion

Build # 1912

Build Type

push

travis-ci

Committed by

ben-manes

Commit Message

Fix deadlock caused by unexpected OutOfMemoryError (fixes #130)

For a small performance gain, scheduling the maintenance work is
performed under a NonReentrantLock. This has a tiny effect, but is
a win since scheduling might happen frequency under load. It only
needed to be re-entrant when a caller-runs policy is used (so the
task locks on the same thread as the one submitting under the lock)
or if an exception is thrown and the maintenance work is performed
directly. The ThreadPoolExecutor and like may throw a
RejectedExecutionException, but ForkJoinPool will never throw. By
default the non-reentrant lock is used, but if a custom executor
is specified then a reentrant one is used since we can't trust
the foreign code.

However, an OutOfMemoryError may be thrown at any time and caused
by unrelated code. So the assumption above was wrong, resulting in
a deadlock. Despite the JVM being in an unpredictable state, its
still a poor response.

The test case covering this scenario was improved to run with the
non-reentrant lock so the deadlock could be observed and corrected.

In addition, removed the Gradle buildscan plugin due to it causing
performance issues due to the large (95k) tests run per test task.

Coverage Stats

5386 of 5749 relevant lines covered (93.69%)

0.94 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1912.1 (TERM=dumb)	06 Nov 2016 05:33AM UTC	0	93.69	Travis Job 1912.1

Source Files on build 1912

Detailed source file information is not available for this build.

ben-manes / caffeine / 1912
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1912

ben-manes / caffeine / 1912 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1912

ben-manes / caffeine / 1912
100%

README BADGES
x