facebook / react / 13978

86%

Pull #8175

travis-ci

<a href="https://github.com/facebook/react/commit/<a class=hub.com/facebook/react/commit/067287b416d7d244eb46ce4e37c5b70832c72c92">067287b41<a href="https://github.com/facebook/react/commit/067287b416d7d244eb46ce4e37c5b70832c72c92">&quot;&gt;Remove pendingUpdate optimization in ReactDOMSelect

This removes an optimization that avoids call update on ReactDOMSelect
twice in an onChange event.

https://github.com/facebook/react/commit/</a><a class="double-link" href="https://github.com/facebook/react/commit/<a class="double-link" href="https://github.com/facebook/react/commit/2601b6a0b0c2b0bccaca67fbbfab6987ac5bef30">2601b6a0b</a>">2601b6a0b</a><a href="https://github.com/facebook/react/commit/067287b416d7d244eb46ce4e37c5b70832c72c92">#commitcomment-19643403

None of the other controlled components do this. The only reason to do it
here is because of the loop.

I&#39;d like to remove this because I&#39;d like to remove all the side-effects
that happen in onChange, other than user defined behavior. I&#39;d also like to
get rid of state that track sequences. It is easier if everything is just
diffing.

Alternatively I can store the previous value that we processed and only
reprocess if the value has changed. However, that would requires the array
for multiple values to be immutable and I don&#39;t think we enforce that
right now.

In Fiber, I believe that we'll be able to batch both these updates into a
single commit.

7 of 7 new or added lines in 1 file covered. (100.0%)

8159 of 9313 relevant lines covered (87.61%)

3082.18 hits per line