os-autoinst / openQA / 3513

100%

push

travis-ci

Fix registration of downloaded assets (broken by 0905559b) (#953)

The change in 0905559b which made `parse_assets_from_settings`
skip any setting with a `_URL` partner was a bad idea. It was
an attempt to fix a real problem, but it went too far.

When `schedule_iso` is run, it calls `parse_assets_from_settings`
and attempts to register all the discovered assets. The problem
is that when an ISO is POSTed with, say, both `KERNEL` and
`KERNEL_URL` specified, `parse_assets_from_settings` will find
the `KERNEL` asset and so `schedule_iso` will try to register
it, but because the download has not run yet, the asset does not
exist yet. The `Schema::ResultSet::Assets->register()` method
which `schedule_iso` calls checks whether the asset file exists
and logs a warning if it doesn't.

The problem with fixing it this way is that every subsequent
effort to register the assets associated with a job runs through
`Schema::Result::Jobs->register_assets_from_settings()` - and
that runs through `parse_assets_from_settings`. Because that now
ignores any asset setting with a `_URL` partner, we *never*
register downloaded assets.

Say we post an ISO with just an `ISO_URL` setting. On the first
registration attempt, at the start of `schedule_iso`, there is
no `ISO` setting at all, so `parse_assets_from_settings` will
not find an ISO asset. So we don't register it there. Next,
`schedule_iso` parses the `ISO_URL` setting and generates a
`ISO` setting from it...but it does not remove the `ISO_URL`
setting when it does this (this is intentional and I believe
correct, I don't think we should change that). So from then on,
the job has both `ISO` and `ISO_URL` settings, so the asset will
never be registered because `parse_assets_from_settings` will
always skip the `ISO` setting because of the existence of the
`ISO_URL` setting.

Note that `register_assets_from_settings` actually includes its
own check for the asset file's existence, which does... (continued)

5 of 5 new or added lines in 2 files covered. (100.0%)

4548 of 6288 relevant lines covered (72.33%)

108.62 hits per line