1818
43%

Ran 06 Jun 2014 05:44AM UTC

Jobs 12

Files 84

Run time 23min

Badge

Embed ▾

pending completion

Build # 1818

Build Type

push

travis-ci

Committed by

gabrielschulhof

Commit Message

Toolbar: Back button correctly appears/disappears on external toolbar

This commit makes the following modifications:
1. Rename _addBackButton() to _updateBackButton() and move the decision making
   as to whether to add or remove a back button from _setOptions() into
   _updateBackButton().

2. Call _updateBackButton() from refresh() as well. This will cause the back
   button to be updated whenever the page changes, because the "pageshow"
   handler is hooked up to refresh().

3. Modify _addHeaderButtonClasses to not recognize the back button as a left
   button.

4. Modify the preconditions for adding a button to include an alternative to
   checking the page's URL for instances where there is no page present - i.e.
   when the toolbar is external. In such cases one must add a back button if
   the active item on the history stack is not the first item.

Closes gh-7188
Fixes gh-6950

Run Details

3576 of 4361 relevant lines covered (82.0%)

861.44 hits per line

Uncovered Existing Lines

Lines	Coverage	File
2	100.0	/home/travis/build/jquery/jquery-mobile/js/widgets/toolbar.js
2	100.0	/home/travis/build/jquery/jquery-mobile/js/navigation.js
2	100.0	/home/travis/build/jquery/jquery-mobile/js/navigation/navigator.js
14	100.0	/home/travis/build/jquery/jquery-mobile/js/widgets/forms/select.custom.js

Jobs

ID	Job ID	Ran	Coverage
1	1818.1 (TYPES=unit JQUERIES=1.8.3)	06 Jun 2014 05:44AM UTC	69.5	Travis Job 1818.1
2	1818.2 (TYPES=unit JQUERIES=1.11.1)	06 Jun 2014 05:45AM UTC	69.46	Travis Job 1818.2
3	1818.3 (TYPES=unit JQUERIES=2.1.1)	06 Jun 2014 05:45AM UTC	69.43	Travis Job 1818.3
4	1818.4 (TYPES=unit JQUERIES=git)	06 Jun 2014 05:46AM UTC	69.46	Travis Job 1818.4
5	1818.5 (TYPES=integration SUITES=!navigation JQUERIES=1.8.3)	06 Jun 2014 05:48AM UTC	74.36	Travis Job 1818.5
6	1818.6 (TYPES=integration SUITES=!navigation JQUERIES=1.11.1)	06 Jun 2014 05:52AM UTC	74.46	Travis Job 1818.6
7	1818.7 (TYPES=integration SUITES=!navigation JQUERIES=2.1.1)	06 Jun 2014 05:53AM UTC	74.46	Travis Job 1818.7
8	1818.8 (TYPES=integration SUITES=!navigation JQUERIES=git)	06 Jun 2014 05:53AM UTC	74.31	Travis Job 1818.8
9	1818.9 (TYPES=integration SUITES=navigation JQUERIES=1.8.3)	06 Jun 2014 06:00AM UTC	72.27	Travis Job 1818.9
10	1818.10 (TYPES=integration SUITES=navigation JQUERIES=1.11.1)	06 Jun 2014 06:01AM UTC	72.08	Travis Job 1818.10
11	1818.11 (TYPES=integration SUITES=navigation JQUERIES=2.1.1)	06 Jun 2014 06:06AM UTC	72.08	Travis Job 1818.11
12	1818.12 (TYPES=integration SUITES=navigation JQUERIES=git)	06 Jun 2014 06:07AM UTC	72.17	Travis Job 1818.12

Source Files on build 1818

Detailed source file information is not available for this build.

jquery / jquery-mobile / 1818
43%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1818

jquery / jquery-mobile / 1818 43%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1818

jquery / jquery-mobile / 1818
43%

README BADGES
x