• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

facebook / react / 13489
86%

Build:
DEFAULT BRANCH: master
Ran 18 Oct 2016 03:50AM UTC
Jobs 1
Files 227
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
13489

push

travis-ci

sebmarkbage
Fix resuming bug

If we abort work but have some completed, we can bail out if
the shouldComponentUpdate returns true. However, then we have
a tree that is low priority. When we bailout we currently use
the "current" tree in this case. I don't think this is right.
I'm not sure why I did that.

Similarly, when we complete we use the "current" props if we
didn't have pending props to do. However, we should be using
the memoized props of that tree if it is a pending work tree.

Added a unit test that covers these two cases.

1 of 1 new or added line in 1 file covered. (100.0%)

7899 of 9012 relevant lines covered (87.65%)

3172.83 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
src/renderers/shared/fiber/ReactFiber.js
2
100.0
src/renderers/shared/fiber/isomorphic/ReactCoroutine.js
3
100.0
src/renderers/shared/fiber/ReactReifiedYield.js
3
100.0
src/renderers/shared/fiber/ReactFiberReconciler.js
7
100.0
src/renderers/shared/fiber/ReactFiberCompleteWork.js
7
100.0
src/renderers/shared/fiber/ReactFiberCommitWork.js
10
100.0
src/renderers/shared/fiber/ReactFiberScheduler.js
15
100.0
src/renderers/shared/fiber/ReactFiberBeginWork.js
32
100.0
src/renderers/noop/ReactNoop.js
32
100.0
src/renderers/dom/fiber/ReactDOMFiber.js
80
100.0
src/renderers/shared/fiber/ReactChildFiber.js
Jobs
ID Job ID Ran Files Coverage
2 13489.2 (TEST_TYPE=test) 18 Oct 2016 03:50AM UTC 0
87.65
Travis Job 13489.2
Source Files on build 13489
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #13489
  • 9c25538e on github
  • Prev Build on master (#13487)
  • Next Build on master (#13491)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc