• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

radiac / mara / 24
77%

Build:
DEFAULT BRANCH: master
Ran 13 Oct 2016 08:58PM UTC
Jobs 4
Files 67
Run time 23s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
24

Pull #3

travis-ci

web-flow
strip NUL characters where it actually matters

bcrypt doesn't handle NUL characters. Probably with that in mind,
mara strips any NUL char from the string that is going to be hashed.
However, the strip is taking place before sha512'ing the password,
and sha512 *can* produce NUL chars.

This patch moves the stripping of NUL characters to the already sha512
hashed string, thus ensuring that no NUL character reaches the bcrypt
hashing function itself.

Note: since this actually changes the hashed password, this change
might not be backwards compatible with your current database.
Pull Request #3: strip NUL characters where it actually matters

1 of 1 new or added line in 1 file covered. (100.0%)

2457 of 3175 relevant lines covered (77.39%)

3.08 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
4
100.0
mara/angel.py
Jobs
ID Job ID Ran Files Coverage
1 24.1 (TOXENV=py27) 13 Oct 2016 08:58PM UTC 0
76.66
Travis Job 24.1
2 24.2 (TOXENV=py33) 13 Oct 2016 08:58PM UTC 0
77.2
Travis Job 24.2
3 24.3 (TOXENV=py34) 13 Oct 2016 08:58PM UTC 0
77.17
Travis Job 24.3
4 24.4 (TOXENV=py35) 13 Oct 2016 08:58PM UTC 0
76.91
Travis Job 24.4
Source Files on build 24
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #24
  • Pull Request #3
  • PR Base - master (#20)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc