• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 44860455944
87%

Build:
DEFAULT BRANCH: master
Ran 21 Nov 2026 03:21AM UTC
Jobs 1
Files 57
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Nov 2026 03:18AM UTC coverage: 87.044% (+0.05%) from 86.997%
44860455944

push

github

web-flow
Keep the widget signed in with AUTH_SEND_JWT_HEADER past token expiry and in Safari (#2352)

* Keep the widget signed in with AUTH_SEND_JWT_HEADER past token expiry and in Safari

Previously, with AUTH_SEND_JWT_HEADER the widget sent the token it held
in memory in X-JWT on every request for as long as the page stayed
open. The auth library reads that header before the cookie, refuses a
token that has expired there and renews only a token from the cookie,
so the first authorised request made after AUTH_TTL_JWT was answered
with 401 and the reader was signed out. The widget now leaves the token
out shortly before it expires when a cookie session exists, and the
request is renewed on the cookie.

Previously, a widget embedded on another site kept its session in a
Partitioned JWT cookie written from script. WebKit refuses that cookie
once an HttpOnly JWT cookie exists for the same host outside the frame,
which an OAuth sign-in or a sign-in on remark42's own domain leaves, so
the reader was signed out by the next reload. The widget now asks for
partitioned cookies with X-Remark42-Partitioned-Cookie, and in this
mode the backend repeats its JWT and XSRF-TOKEN cookies as Partitioned
for such a request, and repeats their expiry for every request.

* Stop writing auth cookies from the widget

Previously, with AUTH_SEND_JWT_HEADER the widget wrote the token from
the X-JWT header to a JWT cookie of its own and the token's jti claim
to an XSRF-TOKEN cookie. Those copies were what kept a session in a
frame on another site, and they are no longer needed there: the backend
now sets its own cookies partitioned for such a frame, and a browser
holding that HttpOnly JWT refuses the script-written one of the same
name anyway. Elsewhere the copies did harm. The token sat where any
script in the frame could read it, and on remark42's own pages the
copy replaced the backend's XSRF-TOKEN cookie with a SameSite=Strict
one, whatever AUTH_SAME_SITE said.

After this change, the... (continued)

37 of 38 new or added lines in 2 files covered. (97.37%)

6927 of 7958 relevant lines covered (87.04%)

52.15 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
96.76
0.02% backend/app/rest/api/middleware.go
Jobs
ID Job ID Ran Files Coverage
1 44860455944.1 21 Nov 2026 03:21AM UTC 57
87.04
GitHub Action Run
Source Files on build 44860455944
  • Tree
  • List 57
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 69445310 on github
  • Prev Build on master (#44859892219)
  • Next Build on master (#44887990220)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc