• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 44848158036
87%

Build:
DEFAULT BRANCH: master
Ran 21 Nov 2026 01:09AM UTC
Jobs 1
Files 57
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Nov 2026 01:06AM UTC coverage: 86.975% (-0.01%) from 86.987%
44848158036

push

github

web-flow
Keep server file paths and the voter's address hash out of error responses (#2365)

* Keep server file paths out of error responses

The errors that several handlers sent to the client carried the
operating system error, which names a file on the server: a missing
picture in previewCommentCtrl and createCommentCtrl, an image store
failure in savePictureCtrl, an avatar store failure in deleteUserCtrl
and deleteMeRequestCtrl, and a temp file failure while an upload is
stored by savePictureCtrl and the import handlers.

These responses now carry a fixed error with the same status, details
and code, and the original error is still logged, through the existing
masking, by the new rest.SendErrorJSONAs. A picture rejected by the
image service as too large, not an image or malformed keeps its
rejection message.

* Leave the address hash out of the same-address vote error

With the same-IP vote restriction on, DataStore.Vote rejected a repeated
vote from one address with an error that included the HMAC of the
voter's IP address, and voteCtrl sent that error to the client. The hash
is the value that stands for the voter's address in admin views and
exports, so the response should not carry it.

The error now names only the comment. It keeps "already voted for",
which parseError maps to the same error code.

27 of 29 new or added lines in 5 files covered. (93.1%)

182 existing lines in 5 files now uncovered.

6778 of 7793 relevant lines covered (86.98%)

50.22 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
79.44
-0.14% backend/app/rest/api/rest_private.go

Coverage Regressions

Lines Coverage ∆ File
79
79.44
-0.14% backend/app/rest/api/rest_private.go
47
90.77
-0.04% backend/app/store/service/service.go
27
82.81
0.0% backend/app/rest/api/migrator.go
20
79.79
0.0% backend/app/rest/api/admin.go
9
68.85
0.0% backend/app/rest/httperrors.go
Jobs
ID Job ID Ran Files Coverage
1 44848158036.1 21 Nov 2026 01:09AM UTC 57
86.98
GitHub Action Run
Source Files on build 44848158036
  • Tree
  • List 57
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 95d3f386 on github
  • Prev Build on master (#44848169515)
  • Next Build on master (#44848298554)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc