• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mindersec / minder / 44808308559
68%

Build:
DEFAULT BRANCH: main
Ran 20 Nov 2026 08:18PM UTC
Jobs 1
Files 362
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

20 Nov 2026 08:06PM UTC coverage: 68.187% (+0.3%) from 67.935%
44808308559

push

github

web-flow
feat(reminder): enable rechecking for artifact entities (#7173)

* feat(reminder): enable rechecking for artifact entities

Fixes #7169

* refactor(reminder): rename repo-specific identifiers to entity-generic names

Addresses non-blocking naming nits from #7171 review -- repos,
repoToLastUpdated, eligibleRepos, repoIds, and the "repo" structured
log key in createReminderMessages are now entity-generic, matching
the entity-type-aware scheduler they describe.

go build ./..., golangci-lint, and
go test ./internal/reminder/... -race -count=1 -- all passing.

* fix(reminder): stop types running before their interval

The half-tick tolerance in isDue let an entity type with an interval
under 1.5x the tick run on every tick, e.g. a 90m artifact interval
ran hourly on a 1h tick. Shrink the slack to a tenth of a tick so it
only absorbs late tick delivery.

Also rename leftover repo-specific loop variables and the reminder
message variable to entity-generic names.

* Run each reminder entity type on its own ticker

Review feedback on #7173 pointed out that one shared ticker at the
shortest interval, with per-type isDue/tolerance checks, was getting
hard to follow and did not honour non-aligned intervals: with types at
5m, 6m and 31m, the shared 5m tick ran the 6m type every 10m and the
31m type every 35m.

The central reminder now only holds shared resources (store, config,
publisher, metrics). Each enabled entity type gets an entityReminder
that owns its cursor, resolved recurrence settings and metrics
attribute, and runs in its own goroutine on a ticker at that type's
exact interval. sendReminders is a method on entityReminder, so the
shared tickInterval and isDue logic is gone.

Stop closes the stop channel, waits on a WaitGroup for every per-type
goroutine to exit, and only then closes the event publisher, so a batch
in flight at shutdown is still published. Interval validation moves to
NewReminder so a bad config fails at construction.

Tests drive the s... (continued)

132 of 154 new or added lines in 2 files covered. (85.71%)

1 existing line in 1 file now uncovered.

24705 of 36231 relevant lines covered (68.19%)

60.66 hits per line

Uncovered Changes

Lines Coverage ∆ File
22
77.17
24.74% internal/reminder/reminder.go

Coverage Regressions

Lines Coverage ∆ File
1
77.17
24.74% internal/reminder/reminder.go
Jobs
ID Job ID Ran Files Coverage
1 44808308559.1 20 Nov 2026 08:18PM UTC 362
68.19
GitHub Action Run
Source Files on build 44808308559
  • Tree
  • List 362
  • Changed 5
  • Source Changed 2
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #44808308559
  • ece7aefe on github
  • Prev Build on main (#44780913225)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc