• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 44494579786
87%

Build:
DEFAULT BRANCH: master
Ran 19 Nov 2026 09:17AM UTC
Jobs 1
Files 56
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

19 Nov 2026 09:14AM UTC coverage: 86.122% (+0.05%) from 86.069%
44494579786

push

github

web-flow
Remove a deleted user's pictures and avatar (#2324)

* Remove a deleted user's pictures along with their comments

Deleting a user blanked their comments but left the pictures uploaded in
them in the image store, while deleting a single comment removes its
pictures. DeleteUser now collects the pictures used in the user's comments
before they are blanked and deletes them once the comments are gone,
keeping any picture another user's comment on the same page also shows,
the same check Delete makes for one comment. This covers the delete-me
link, the admin user deletion and a permanent block, which all go through
DeleteUser.

A failed picture lookup is logged and does not stop the user deletion,
and no picture is removed when the comment deletion fails. The paging
over the user's comments stops on a page with nothing new, so an engine
that ignores Skip cannot loop forever.

* Remove the avatar when an admin deletes a user

Admin user deletion left the user's avatar in the avatar store,
although the delete-me handler already removed it. The route carries only the user ID, so it now reads the
avatar address from one of the user's comments before the hard delete
clears it, and removes the avatar the way the delete-me handler does: an
avatar that is already gone is not an error, a store failure is. Both
handlers share the removal in removeAvatar.

* Remove the avatar before the comments on admin user deletion

The admin user deletion removed the avatar after deleting the comments.
When the avatar store failed, the handler returned an error without
flushing the cache, so the deleted comments kept being served, and a
retry found no comments to read the avatar from, reported success and
left the avatar in place. The avatar is now removed first: a failure
leaves the user untouched for a retry, and a retry after a failed
comment deletion meets an avatar that is already gone, which is not an
error. The cache is flushed whenever the comments were deleted.

* Flush ... (continued)

80 of 89 new or added lines in 2 files covered. (89.89%)

6249 of 7256 relevant lines covered (86.12%)

46.91 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
90.5
0.1% backend/app/store/service/service.go
4
78.21
1.19% backend/app/rest/api/admin.go
Jobs
ID Job ID Ran Files Coverage
1 44494579786.1 19 Nov 2026 09:17AM UTC 56
86.12
GitHub Action Run
Source Files on build 44494579786
  • Tree
  • List 56
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 9d778ce2 on github
  • Prev Build on master (#44465776936)
  • Next Build on master (#44495061996)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc