• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / remark42 / 44465122774
87%

Build:
DEFAULT BRANCH: master
Ran 19 Nov 2026 05:29AM UTC
Jobs 1
Files 56
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

19 Nov 2026 05:25AM UTC coverage: 86.09% (+0.04%) from 86.052%
44465122774

push

github

umputun
Check the target host, not the proxy, when safehttp fetches through a proxy

safehttp.Transport kept http.DefaultTransport's ProxyFromEnvironment and
checked addresses only in DialContext. With HTTP_PROXY or HTTPS_PROXY set,
the dialer sees the proxy's address and never the target's, so a proxy on
a private address refused every proxied image and title fetch, and a proxy on a
public address passed any target, including link-local and private ones,
through unchecked.

The transport now reads the proxy settings itself and wraps the Proxy
hook: when a request goes through a proxy, the target host is resolved
and refused if any of its addresses is private, and the dialer lets the
proxy's own address through. A direct request to the proxy's address,
which NO_PROXY or the loopback exemption can produce, is checked in the
hook as well. The proxy resolves the target name itself, so the check
covers address literals and what the local resolver returns, not the
address the proxy finally connects to.

The proxy settings are read with golang.org/x/net/http/httpproxy, the
package ProxyFromEnvironment uses, now vendored.

43 of 50 new or added lines in 1 file covered. (86.0%)

6152 of 7146 relevant lines covered (86.09%)

45.34 hits per line

Uncovered Changes

Lines Coverage ∆ File
7
84.93
9.93% backend/app/safehttp/safehttp.go
Jobs
ID Job ID Ran Files Coverage
1 44465122774.1 19 Nov 2026 05:29AM UTC 56
86.09
GitHub Action Run
Source Files on build 44465122774
  • Tree
  • List 56
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 39fa75ba on github
  • Prev Build on master (#44463788320)
  • Next Build on master (#44465776936)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc