• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mindersec / minder / 44245115000
68%

Build:
DEFAULT BRANCH: main
Ran 18 Nov 2026 05:46AM UTC
Jobs 1
Files 362
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Nov 2026 05:33AM UTC coverage: 67.743% (+0.08%) from 67.66%
44245115000

push

github

web-flow
fix(oci): wire registry authenticator through OCI provider calls (#7042)

* fix(oci): wire registry authenticator through OCI provider calls

Adds an optional WithRegistryAuthenticator option so GHCR's existing
Basic-auth credential reaches the 6 previously-anonymous call sites in
oci.go. Docker Hub and Quay remain unchanged (anonymous) since their
auth shape needs separate verification. Also fixes GetReferrer, which
built its digest reference from RepositoryStr() and always queried
Docker Hub regardless of the actual registry.

Fixes #6972 (partial — Docker Hub/Quay credential wiring tracked
separately).

* Skip GHCR auth for GitHub App providers

GHCR doesn't accept GitHub App installation tokens today (see
github.com/orgs/community/discussions/171423, still unanswered as of
Sep 2026), so wiring the registry authenticator for every GitHub
provider class would break public-image access for App-backed
providers.

Gate the authenticator to github-class (OAuth/PAT) providers only:
- NewGitHub only passes WithRegistryAuthenticator when
  providerClass == db.ProviderClassGithub
- Added GetContainerAuthenticator(owner) to the provifv1.GitHub
  interface so the Sigstore verifier can check the same gate instead
  of reading the raw credential directly
- App-backed providers (github-app) stay anonymous for GHCR, same as
  before this change

Testing: TestGHCRAuthByProviderClass covers both provider classes
(github gets Basic auth, github-app gets anonymous), plus a new test
confirming the verifier never bypasses the gate.

* Share GHCR provider-class check in one helper

Both NewGitHub and GetContainerAuthenticator decided whether to send
the provider token to GHCR with opposite class comparisons. Route both
through isOAuthBackedGitHub so they cannot drift, and document the
GitHub App token limitation once on the helper.

Drop the test-only OCI.RegistryAuthenticator accessor; the test now
deep-compares the constructed OCI client instead.

54 of 55 new or added lines in 3 files covered. (98.18%)

3 existing lines in 2 files now uncovered.

24420 of 36048 relevant lines covered (67.74%)

60.32 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
79.79
6.58% internal/providers/oci/oci.go

Coverage Regressions

Lines Coverage ∆ File
2
93.94
-6.06% pkg/datasources/v1/registry.go
1
69.7
-0.3% internal/authz/authz.go
Jobs
ID Job ID Ran Files Coverage
1 44245115000.1 18 Nov 2026 05:46AM UTC 362
67.74
GitHub Action Run
Source Files on build 44245115000
  • Tree
  • List 362
  • Changed 6
  • Source Changed 4
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #44245115000
  • 388dcc30 on github
  • Prev Build on main (#44245017885)
  • Next Build on main (#44271688264)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc