• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / inference-perf / 44142103159
87%

Build:
DEFAULT BRANCH: main
Ran 17 Nov 2026 06:08PM UTC
Jobs 1
Files 144
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Nov 2026 05:54PM UTC coverage: 86.752% (-0.03%) from 86.778%
44142103159

push

github

web-flow
fix(utils): allow inference_perf to import on Windows (#1058)

Fixes #1053

## Summary

Allow the package to import on Windows without changing Linux/macOS
forkserver behavior.

## Root cause

PR #526 unconditionally imported `ForkServerContext` and
`ForkServerProcess`, which do not exist on Windows. A fresh Python
3.12.10 interpreter on clean main fails with:

```text
ImportError: cannot import name 'ForkServerContext' from 'multiprocessing.context'
```

`uvloop` was the second blocker on the same path: it has no Windows
wheel and `load_generator.py` imported it at module scope. This is
distinct from the spawn/pickling limitations tracked in #305.

## Changes

- On Windows, use `multiprocessing.get_context("spawn")`, expose
`SpawnProcess` under the existing `PreloadedForkServerProcess` name, and
make `start_forkserver()` a no-op.
- Keep concrete platform-specific context types and explicit public
exports; no `Any`, casts, or type-checker suppressions added.
- Preserve the POSIX startup function, process/context implementations,
preload list, and `JE_ARROW_MALLOC_CONF` logic. Their ASTs match main.
- Guard the `uvloop` import and its `EventLoopPolicy` use behind
`sys.platform != "win32"`, and marker-gate the dependency in
`pyproject.toml` with `sys_platform != 'win32'`. `pdm.lock` records the
matching marker, so `pdm lock --check` is clean.
- Add three tests that CI executes: a fresh-interpreter import, the
context start method plus its process class, and a POSIX primitives test
that starts a real forkserver child and transfers a manager list back.
- **The only edit to an existing test file** is a Windows module-level
skip guard before imports in `tests/required/utils/test_mp_context.py`.
Its existing Linux forkserver tests are otherwise untouched.
- Document the platform split without claiming full Windows benchmark
support.

## Verification

- Focused tests: **2 passed, 2 skipped** on Windows; the POSIX
primitives and forkserver tests are the skippe... (continued)

31 of 37 new or added lines in 2 files covered. (83.78%)

1 existing line in 1 file now uncovered.

14439 of 16644 relevant lines covered (86.75%)

0.87 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
86.11
-10.19% inference_perf/utils/mp_context.py
1
85.94
-0.04% inference_perf/loadgen/load_generator.py

Coverage Regressions

Lines Coverage ∆ File
1
79.17
-1.04% inference_perf/datagen/base.py
Jobs
ID Job ID Ran Files Coverage
1 44142103159.1 17 Nov 2026 06:08PM UTC 144
86.75
GitHub Action Run
Source Files on build 44142103159
  • Tree
  • List 144
  • Changed 3
  • Source Changed 2
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #44142103159
  • a3ba0893 on github
  • Prev Build on main (#44140647921)
  • Next Build on main (#44168932103)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc