• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

google / OpenSK / 44065254751
98%
2.1: 97%

Build:
Build:
LAST BUILD BRANCH: uv-retries-before-match
DEFAULT BRANCH: 2.1
Ran 17 Nov 2026 10:33AM UTC
Jobs 1
Files 41
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Nov 2026 10:29AM UTC coverage: 97.641% (+0.06%) from 97.584%
44065254751

push

github

web-flow
Verifies credential management pinUvAuthParam over the received parameters (#841)

* Verifies credential management pinUvAuthParam over the received parameters

The platform computes pinUvAuthParam over the subCommandParams it
sends, but the authenticator re-encoded the parsed parameters before
verifying it. Parsing drops unknown entries such as unknown transports,
so a request with "transports": ["usb", "smart-card"] failed with
CTAP2_ERR_PIN_AUTH_INVALID although its MAC was correct. Keep the CBOR
value the parameters were parsed from and verify the MAC over it.

* Verifies pinUvAuthParam over subCommandParams before parsing them

authenticatorCredentialManagement, authenticatorBioEnrollment and
authenticatorConfig now keep subCommandParams as the received CBOR value
until the pinUvAuthParam over them is verified, and parse them after that.
Parsing ignores unknown map keys, transports and credential types, so the
parsed parameters encoded again could differ from what the platform
authenticated.

This replaces the copy of the received parameters from the previous
commit. The value is moved into the MAC message and decoded from it again,
so no second copy is kept. The conversions to CBOR that only existed to
encode parameters for the MAC are removed, and so is ConfigSubCommandParams.
Errors in subCommandParams are now returned after the pinUvAuthParam
checks, following the order of operations in the specification.

* Reassigns subCommandParams instead of shadowing them

Makes the destructured sub_command_params mutable in process_config and
process_credential_management, so the verified parameters replace them
in place and the else and match arms no longer pass them through.

* Updates test_enrollment_database_full for raw subCommandParams

PR #840 added test_enrollment_database_full on develop using BioEnrollmentSubCommandParams, which conflicted semantically after AuthenticatorBioEnrollmentParameters.sub_command_params changed to Option<cbor::Value>... (continued)

338 of 338 new or added lines in 6 files covered. (100.0%)

15230 of 15598 relevant lines covered (97.64%)

3844.75 hits per line

Jobs
ID Job ID Ran Files Coverage
1 44065254751.1 17 Nov 2026 10:33AM UTC 41
97.64
GitHub Action Run
Source Files on build 44065254751
  • Tree
  • List 41
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 2a2d185c on github
  • Prev Build on develop (#44046205545)
  • Next Build on develop (#44332786402)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc