• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

cameri / nostream / 43936235076
79%

Build:
DEFAULT BRANCH: main
Ran 16 Nov 2026 07:13PM UTC
Jobs 2
Files 339
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Nov 2026 07:08PM UTC coverage: 79.249% (+0.04%) from 79.208%
43936235076

push

github

web-flow
fix(admin): hold the settings write lock for every writer (#1118)





<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
A settings PATCH read settings.yaml before saving it, while the
moderation writer read and rewrote the file under the settings write
lock. The two could interleave, so an ordinary admin save silently
reverted a ban written by the other request.

- read, validate and save inside withSettingsWriteLock in the settings,
notifications, restore and CLI writers
- keep audit and outbox work outside the lock so it is not held across
I/O
- add regression tests showing the read happens inside the lock and a
ban written before acquisition survives the save
## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
Fixes #1039
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Non-functional change (docs, style, minor refactor)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
- [ ] My code follows the code style of this project.
-... (continued)

5437 of 7449 branches covered (72.99%)

Branch coverage included in aggregate %.

80 of 104 new or added lines in 5 files covered. (76.92%)

11474 of 13890 relevant lines covered (82.61%)

677.9 hits per line

Uncovered Changes

Lines Coverage ∆ File
16
16.75
-0.53% src/cli/commands/config.ts
8
87.49
-0.1% src/utils/settings-config.ts
Jobs
ID Job ID Ran Files Coverage
1 Integration - 43936235076.1 16 Nov 2026 07:13PM UTC 339
34.95
GitHub Action Run
2 Unit - 43936235076.2 16 Nov 2026 07:14PM UTC 339
77.13
GitHub Action Run
Source Files on build 43936235076
  • Tree
  • List 339
  • Changed 8
  • Source Changed 5
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #43936235076
  • 7bbbce94 on github
  • Prev Build on main (#43917979809)
  • Next Build on main (#43977599943)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc