• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

enbility / spine-go / 43865522605
93%

Build:
DEFAULT BRANCH: dev
Ran 16 Nov 2026 12:21PM UTC
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Nov 2026 12:19PM UTC coverage: 92.985% (+0.04%) from 92.949%
43865522605

push

github

web-flow
fix(spine): only validate serverFeatureType against the server feature (#108)

## Problem

`AddBinding` and `AddSubscription` currently validate the optional
`serverFeatureType` against **both** involved features. The second check
targets the requesting **client** feature, whose type is not constrained
by SPINE.

`serverFeatureType` identifies the feature the binding/subscription
targets and therefore applies **only to the server-side feature**.

As a result, an EnergyGuard advertising `DeviceClassification` (or a
type introduced by a future SPINE version) is rejected with a
`LoadControl` type mismatch, causing LPC/LPP commissioning to fail.

**TC_SPINE_RTS_001** and **TC_SPINE_RTS_002** require this to be
tolerated.

## Change

`checkRoleAndType` now skips the type check for features without the
server role. Role validation remains unchanged.

**Scope:** 7 lines changed per file; no signature, call-site, or import
changes.

## Tests

- Added `TestRTS001_Commissioning_*` and `TestRTS002_Commissioning_*` to
`rts_forward_compat_test.go`, covering the failing commissioning step.
- Added regressions ensuring mismatching **server** feature types are
still rejected.
- Removed the stale panic comment fixed by #99.

## Relation to #99

#99 fixed unknown `featureType` handling in the Discovery path. This PR
fixes the separate type-checking path that still causes RTS_001/002 to
fail after #99.

RTS_001 uses the known `DeviceClassification` type and therefore never
hit the panic path; RTS_002 reaches the same type check after the panic
fix.

6 of 6 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

6283 of 6757 relevant lines covered (92.99%)

25621.01 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
89.82
-0.3% spine/feature_local.go
Jobs
ID Job ID Ran Files Coverage
1 43865522605.1 16 Nov 2026 12:21PM UTC 63
92.99
GitHub Action Run
Source Files on build 43865522605
  • Tree
  • List 63
  • Changed 3
  • Source Changed 2
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43865522605
  • 7d68ea6c on github
  • Prev Build on dev (#43865412389)
  • Next Build on dev (#43865571607)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc